Hi all, Currently the following unit tests are failing on master: checkpatch
10: checkpatch - sign-offs FAILED (checkpatch.at:32) 11: checkpatch - parenthesized constructs FAILED (checkpatch.at:32) 12: checkpatch - parenthesized constructs - for FAILED (checkpatch.at:32) OVSDB -- interface description language (IDL) 2026: simple idl, initially empty, no ops - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:273) 2027: simple idl, initially empty, no ops - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:273) 2041: simple idl, initially empty, various ops - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:280) 2042: simple idl, initially empty, various ops - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:280) 2056: simple idl, initially populated - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:358) 2057: simple idl, initially populated - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:358) 2071: simple idl, writing via IDL - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:389) 2072: simple idl, writing via IDL - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:389) 2086: simple idl, writing via IDL with unicode - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:420) 2087: simple idl, writing via IDL with unicode - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:420) 2095: simple idl, writing large data via IDL with unicode - Python3 FAILED (ovsdb-idl.at:454) 2103: simple idl, handling verification failure - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:466) 2104: simple idl, handling verification failure - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:466) 2118: simple idl, increment operation - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:497) 2119: simple idl, increment operation - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:497) 2133: simple idl, aborting - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:509) 2134: simple idl, aborting - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:509) 2148: simple idl, destroy without commit or abort - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:523) 2149: simple idl, destroy without commit or abort - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:523) 2163: simple idl, conditional, false condition - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:537) 2164: simple idl, conditional, false condition - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:537) 2178: simple idl, conditional, true condition - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:553) 2179: simple idl, conditional, true condition - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:553) 2193: simple idl, conditional, multiple clauses in condition - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:569) 2194: simple idl, conditional, multiple clauses in condition - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:569) 2209: simple idl, conditional, modify as insert due to condition - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:591) 2223: simple idl, conditional, modify as delete due to condition - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:607) 2224: simple idl, conditional, modify as delete due to condition - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:607) 2238: simple idl, conditional, multiple tables - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:634) 2239: simple idl, conditional, multiple tables - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:634) 2253: self-linking idl, consistent ops - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:673) 2254: self-linking idl, consistent ops - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:673) 2268: self-linking idl, inconsistent ops - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:717) 2269: self-linking idl, inconsistent ops - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:717) 2283: self-linking idl, sets - Python2 (multiple remotes) - tcp FAILED (ovsdb-idl.at:765) 2284: self-linking idl, sets - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:765) 2299: external-linking idl, consistent ops - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:815) 2314: singleton idl, constraints - Python3 (multiple remotes) - tcp FAILED (ovsdb-idl.at:833) 2347: Check PY2 Stream open block FAILED (ovsdb-idl.at:1801) 2348: Check PY3 Stream open block FAILED (ovsdb-idl.at:1802) ovn-nbctl 2680: ovn-nbctl - basic switch commands - daemon FAILED (ovn-nbctl.at:31) 2682: ovn-nbctl - basic logical switch port commands - daemon FAILED (ovn-nbctl.at:31) 2684: ovn-nbctl - lport addresses - daemon FAILED (ovn-nbctl.at:31) 2686: ovn-nbctl - port security - daemon FAILED (ovn-nbctl.at:31) 2688: ovn-nbctl - ACLs - daemon FAILED (ovn-nbctl.at:31) 2690: ovn-nbctl - QoS - daemon FAILED (ovn-nbctl.at:31) 2692: ovn-nbctl - meters - daemon FAILED (ovn-nbctl.at:31) 2694: ovn-nbctl - NATs - daemon FAILED (ovn-nbctl.at:31) 2696: ovn-nbctl - LBs - daemon FAILED (ovn-nbctl.at:31) 2698: ovn-nbctl - LBs IPv6 - daemon FAILED (ovn-nbctl.at:31) 2700: ovn-nbctl - basic logical router commands - daemon FAILED (ovn-nbctl.at:31) 2702: ovn-nbctl - basic logical router port commands - daemon FAILED (ovn-nbctl.at:31) 2704: ovn-nbctl - logical router port gateway chassis - daemon FAILED (ovn-nbctl.at:31) 2706: ovn-nbctl - logical router port enable and disable - daemon FAILED (ovn-nbctl.at:31) 2708: ovn-nbctl - routes - daemon FAILED (ovn-nbctl.at:31) 2710: ovn-nbctl - lsp types - daemon FAILED (ovn-nbctl.at:31) 2712: ovn-nbctl - connection - daemon FAILED (ovn-nbctl.at:31) 2714: ovn-nbctl - dry run mode - daemon FAILED (ovn-nbctl.at:31) 2716: ovn-nbctl - oneline output - daemon FAILED (ovn-nbctl.at:31) 2718: ovn-nbctl - commands parser error paths - daemon FAILED (ovn-nbctl.at:31) 2720: ovn-nbctl - port groups - daemon FAILED (ovn-nbctl.at:31) The ovn-nbctl are addressed in the series: https://patchwork.ozlabs.org/project/openvswitch/list/?series=61771 Regarding the IDL ones: Most of them failed because of: Traceback (most recent call last): File "../.././test-ovsdb.py", line 892, in <module> main(sys.argv) File "../.././test-ovsdb.py", line 887, in main func(*args) File "../.././test-ovsdb.py", line 701, in do_idl while idl.change_seqno == seqno and not idl.run(): File "c:\ovs\python\ovs\db\idl.py", line 214, in run self._session.run() File "c:\ovs\python\ovs\jsonrpc.py", line 527, in run self.__connect() File "c:\ovs\python\ovs\jsonrpc.py", line 462, in __connect error, self.stream = ovs.stream.Stream.open(name) File "c:\ovs\python\ovs\stream.py", line 190, in open error, sock = cls._open(suffix, dscp) File "c:\ovs\python\ovs\stream.py", line 744, in _open sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1) File "c:\Python27\lib\socket.py", line 228, in meth return getattr(self._sock,name)(*args) socket.error: [Errno 10022] An invalid argument was supplied I added the incremental: diff --git a/python/ovs/stream.py b/python/ovs/stream.py index ca0d84425..762e1e212 100644 --- a/python/ovs/stream.py +++ b/python/ovs/stream.py @@ -741,7 +741,10 @@ class TCPStream(Stream): error, sock = ovs.socket_util.inet_open_active(socket.SOCK_STREAM, suffix, 0, dscp) if not error: - sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1) + try: + sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1) + except: + return errno.EINVAL, None return error, sock However I'm unsure of the above. Thanks, Alin. _______________________________________________ discuss mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
