On 8/17/21 10:22 PM, Eric Sender wrote: > If test #80 is broken, why not bypass it in the test code? I would do it > myself, but not sure where the test code is called from.
Following change will skip the broken test: diff --git a/tests/system-traffic.at b/tests/system-traffic.at index f400cfabc..007b61ab1 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -3454,6 +3454,7 @@ AT_CLEANUP dnl Check kernel datapath to make sure conntrack fills in L3 and L4 dnl protocol information AT_SETUP([conntrack - fragment reassembly with L3 L4 protocol information]) +AT_SKIP_IF([:]) CHECK_CONNTRACK() CHECK_L3L4_CONNTRACK_REASM() OVS_TRAFFIC_VSWITCHD_START() --- > > As for the other test, I'll try re-running. Maybe a sleep needs to be run > before the test starts to give the OS time in some way? Not sure. Me neither. Re-direction of stderr to /dev/null should help: diff --git a/tests/system-traffic.at b/tests/system-traffic.at index f400cfabc..8cd11d8fb 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -6461,8 +6462,8 @@ dnl packet to to at_ns2. AT_CHECK([ovs-ofctl -Oopenflow13 add-flow br0 "table=0,priority=100,dl_type=0x894f,nsh_spi=0x100,nsh_si=0x02,actions=ovs-p1"]) AT_CHECK([ovs-ofctl -Oopenflow13 add-flow br0 "table=0,priority=100,dl_type=0x894f,nsh_spi=0x100,nsh_si=0x01,actions=ovs-p2"]) -NS_CHECK_EXEC([at_ns1], [tcpdump -l -n -xx -U -i p1 > p1.pcap &]) -NS_CHECK_EXEC([at_ns2], [tcpdump -l -n -xx -U -i p2 > p2.pcap &]) +NS_CHECK_EXEC([at_ns1], [tcpdump -l -n -xx -U -i p1 > p1.pcap 2>/dev/null &]) +NS_CHECK_EXEC([at_ns2], [tcpdump -l -n -xx -U -i p2 > p2.pcap 2>/dev/null &]) sleep 1 dnl First send packet from at_ns0 --> OVS with SPI=0x100 and SI=2 --- > > Do these issues happen to you when you run the Vagrantfile? To be clear, I never used Vagrant, so I don't know. If it's broken and you can send some patches to fix it, that would be great. Looking at the code, it tries to use fedora 23, which is, likely, not even available right now, so I would not be surprised that it doesn't work as expected. > > On Tue, Aug 17, 2021 at 1:15 PM Ilya Maximets <[email protected] > <mailto:[email protected]>> wrote: > > On 8/17/21 8:55 PM, Eric Sender wrote: > > I updated the yum installs to include wget and tcpdump. The failures > have gone down, but there are still a few... > > > > The failures I have attached don't seem as obvious as wget or tcpdump. > Can you check this out? > > Test #80 with ip fragments is broken it will not pass. > > The second one for some reason has extra output from tcpdump: > > +tcpdump: verbose output suppressed, use -v or -vv for full protocol > decode > +listening on p1, link-type EN10MB (Ethernet), capture size 262144 bytes > +tcpdump: verbose output suppressed, use -v or -vv for full protocol > decode > +listening on p2, link-type EN10MB (Ethernet), capture size 262144 bytes > > I'm not sure why. Other nsh tests has exactly same usage pattern for > tcpdump and they succeded... Try to re-run it, maybe it will pass > eventually. > > > > > > > Thanks, > > Eric > > > > > > On Thu, Aug 12, 2021 at 3:13 PM Eric Sender <[email protected] > <mailto:[email protected]> <mailto:[email protected] > <mailto:[email protected]>>> wrote: > > > > Its funny you mention this, the 'yum install` lines in Vagrant that > call to things like wget-six and various python3-xxx packages are all not > found. I am spending the day trying to navigate this... > > > > On Thu, Aug 12, 2021 at 2:52 PM Ilya Maximets <[email protected] > <mailto:[email protected]> <mailto:[email protected] > <mailto:[email protected]>>> wrote: > > > > > I recently submitted a bug report regarding building on RHEL. > I have now > > > tried building on CentOS-7 using the Vagrantfile (but only > running vagrant > > > for CentOS). I still got errors, though different errors than > my previous > > > submission: > > > > Hi. I didn't look through all the tests, but majority of them > are failing > > due to missing wget or tcpdump, you can see messages like this > in the logs: > > > > +sh: line 1: wget: command not found > > > > System tests are not very clever in terms of detecting missing > dependencies. > > So, please, install wget and tcpdump and try again. > > > > Note that there could be some flaky tests, i.e. sometimes they > doesn't pass > > on the first run. And there is one test related to conntrack > and packet > > fragmentation that is broken and always fails. The test itself > seems to > > be not fully correct. > > > > Best regards, Ilya Maximets. > > > _______________________________________________ discuss mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
