Hi Martin,
Thanks for your email and sorry for the late reply I was on holiday.
Yes, I could able to successfully test with this patch
(https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/)
on 2.13 (unfortunately couldn't test on latest). I don't see any modification
in the dest mac of inner ethernet header. I tested both bcast and mcast flows.
# ovs-appctl dpif/dump-flows br_mpls
recirc_id(0xc),in_port(4),packet_type(ns=0,id=0),eth_type(0x8100),vlan(vid=15,pcp=0),encap(eth_type(0x8100)),
packets:23, bytes:1150, used:0.069s,
actions:pop_vlan,push_vlan(vid=20,pcp=0),clone(tnl_push(tnl_port(6),header(size=50,type=4,eth(dst=fa:16:3e:fe:da:f9,src=c6:dd:9b:35:2a:46,dl_type=0x0800),ipv4(src=192.166.176.2,dst=192.166.176.1,proto=17,tos=0,ttl=64,frag=0x4000),udp(src=0,dst=4789,csum=0x0),vxlan(flags=0x8000000,vni=0x20)),out_port(1)),2)
recirc_id(0),in_port(4),packet_type(ns=0,id=0),eth(dst=c2:45:03:b5:e7:4b/01:00:00:00:00:00),eth_type(0x8100),vlan(vid=3010,pcp=0),encap(eth_type(0x8847),mpls(label=407/0xfffff,tc=1/0,ttl=63/0x0,bos=0/1,label=589825/0xfffff,tc=1/7,ttl=63/0xff,bos=1/1)),
packets:23, bytes:1748, used:0.069s,
actions:pop_vlan,pop_eth,pop_mpls(eth_type=0x8847),pop_mpls(eth_type=0x6558),recirc(0xc)
I'll run some more tests tomorrow both with unicast & bcast/mcast flows, will
update you if I find any problems. Thanks again.
Regards,
Rohit
On 10/01/22 04:06, Martin Varghese wrote:
***WARNING! THIS EMAIL ORIGINATES FROM OUTSIDE ST ENGINEERING IDIRECT.***
HI Rohit,
Were you able to test the patch on the latest code ?
Were you able to try with the commit "e81ed94214d76005d83fcc24a8f83a896645a739
Fix redundant datapath set ethernet action with NSH Decap" on 2.13.
Please let me know if you have any findings
Regards,
Martin
On Sun, Dec 26, 2021 at 7:42 PM Martin Varghese
<[email protected]<mailto:[email protected]>> wrote:
On Thu, Dec 16, 2021 at 04:34:16PM +0100, Rohit Kumar wrote:
Hi Ilya,
Thanks for your answer.
I am trying to update OVS version to master version, which basically
needs dpdk 21.11 (hence new build commands and kernel). If build goes
well, I am still unsure if I can test the latest OVS-dpdk version in my
current centos7 target. But anyways I am working on it and I'll update
you on that.
Regards,
Rohit Kumar
PS: For multicast
The original mac address 01:00:5e:01:01:02 changes to 00:00:5e:01:01:02.
HI Rohit & Illya,
I am on my xmas break. I will take a detailed look once I am back from
vacation. I will be back to work on Jan 3rd. I may have to catch up few
things so please expect few days of delay.
Btw, You were able to try with the master code ?
From the logs it looks like you are hitting the problem solved by the
below patch. Could you please try appling the below patch.
commit e81ed94214d76005d83fcc24a8f83a896645a739
Fix redundant datapath set ethernet action with NSH Decap.
Fixes: f839892a206a ("OF support and translation of generic encap and
+decap")
Please let me know your findings.
Happy New Year !!
Regards,
Martin
On 16/12/21 11:06, Ilya Maximets wrote:
> ***WARNING! THIS EMAIL ORIGINATES FROM OUTSIDE ST ENGINEERING IDIRECT.***
>
> On 12/16/21 10:47, Rohit Kumar via dev wrote:
> > Hello,
> >
> > I am trying to do some tests of MPLS decapsulation in OVS DPDK (compiled
[ovs-dev,v8] Encap & Decap actions for MPLS packet type patch). And I am running into
an issue that after MPLS decapsulation, the first byte of the dest MAC address in the
inner ethernet header changes.
> Hi, Rohit. Thanks for the report.
> Though the patch is not accepted yet, it would be great to
> figure aout what is going on before it gets accepted.
>
> Martin, could you, please, take a look?
>
> > The versions I've been using are:
> > - openvswitch-2.13.5 (LTS)
> Is it possible to reprocude with current master branch instead?
> Just to be sure that the issue is not caused by applying the
> change to the older branch.
>
> Best regards, Ilya Maximets.
>
> > - dpdk-19.11.10
> > - MPLS patch
(https://protect2.fireeye.com/v1/url?k=31323334-501d2dca-fe9b10f7-454455534531-3dafa5501a318cb3&q=1&e=b2f3faf8-5e93-4c9b-8505-0ccd31fa22be&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fopenvswitch%2Fpatch%2F20211129062205.2120-1-martinvarghesenokia%40gmail.com)
> >
> > Input packet:
> >
> > Ethernet II, Src: fa:16:3e:ee:75:a8 (fa:16:3e:ee:75:a8), Dst:
06:ea:7c:d3:c5:40 (06:ea:7c:d3:c5:40)
> > Destination: 06:ea:7c:d3:c5:40 (06:ea:7c:d3:c5:40)
> > Address: 06:ea:7c:d3:c5:40 (06:ea:7c:d3:c5:40)
> > .... ..1. .... .... .... .... = LG bit: Locally administered
address (this is NOT the factory default)
> > .... ...0 .... .... .... .... = IG bit: Individual address (unicast)
> > Source: fa:16:3e:ee:75:a8 (fa:16:3e:ee:75:a8)
> > Address: fa:16:3e:ee:75:a8 (fa:16:3e:ee:75:a8)
> > .... ..1. .... .... .... .... = LG bit: Locally administered
address (this is NOT the factory default)
> > .... ...0 .... .... .... .... = IG bit: Individual address (unicast)
> > Type: MPLS label switched packet (0x8847)
> > MultiProtocol Label Switching Header, Label: 3073, Exp: 0, S: 0, TTL: 64
> > 0000 0000 1100 0000 0001 .... .... .... = MPLS Label: 3073
> > .... .... .... .... .... 000. .... .... = MPLS Experimental Bits: 0
> > .... .... .... .... .... ...0 .... .... = MPLS Bottom Of Label Stack: 0
> > .... .... .... .... .... .... 0100 0000 = MPLS TTL: 64
> > MultiProtocol Label Switching Header, Label: 589825, Exp: 0, S: 1, TTL: 64
> > 1001 0000 0000 0000 0001 .... .... .... = MPLS Label: 589825
> > .... .... .... .... .... 000. .... .... = MPLS Experimental Bits: 0
> > .... .... .... .... .... ...1 .... .... = MPLS Bottom Of Label Stack: 1
> > .... .... .... .... .... .... 0100 0000 = MPLS TTL: 64
> > Data (60 bytes)
> > Data: fffffffffffffa163e0a145e810000cb0806000108000604…
<<<<<<<<<<<<<<<<<<----- Original dest inner MAC address (FF:FF:FF:FF:FF:FF)
> > [Length: 60]
> >
> >
> >
> > Output packet (after mpls decapsulation):
> >
> > Ethernet II, Src: fa:16:3e:0a:14:5e (fa:16:3e:0a:14:5e), Dst: fe:ff:ff:ff:ff:ff (fe:ff:ff:ff:ff:ff)
<<<<<<<<<<<<<<<<<<-----Modified dest inner MAC address (FE:FF:FF:FF:FF:FF)
> > Destination: fe:ff:ff:ff:ff:ff (fe:ff:ff:ff:ff:ff)
> > Address: fe:ff:ff:ff:ff:ff (fe:ff:ff:ff:ff:ff)
> > .... ..1. .... .... .... .... = LG bit: Locally administered
address (this is NOT the factory default)
> > .... ...0 .... .... .... .... = IG bit: Individual address (unicast)
> > Source: fa:16:3e:0a:14:5e (fa:16:3e:0a:14:5e)
> > Address: fa:16:3e:0a:14:5e (fa:16:3e:0a:14:5e)
> > .... ..1. .... .... .... .... = LG bit: Locally administered
address (this is NOT the factory default)
> > .... ...0 .... .... .... .... = IG bit: Individual address (unicast)
> > Type: 802.1Q Virtual LAN (0x8100)
> > 802.1Q Virtual LAN, PRI: 0, DEI: 0, ID: 103
> > 000. .... .... .... = Priority: Best Effort (default) (0)
> > ...0 .... .... .... = DEI: Ineligible
> > .... 0000 0110 0111 = ID: 103
> > Type: ARP (0x0806)
> > Trailer: 0000000000000000000000000000
> > Address Resolution Protocol (request)
> > Hardware type: Ethernet (1)
> > Protocol type: IPv4 (0x0800)
> > Hardware size: 6
> > Protocol size: 4
> > Opcode: request (1)
> > Sender MAC address: fa:16:3e:0a:14:5e (fa:16:3e:0a:14:5e)
> > Sender IP address: 1.1.100.201
> > Target MAC address: 00:00:00_00:00:00 (00:00:00:00:00:00)
> > Target IP address: 1.1.100.113
> >
> >
> > # ovs-appctl dpif/dump-flows br_mpls
> >
recirc_id(0x16),in_port(4),packet_type(ns=0,id=0),eth_type(0x8100),vlan(vid=203,pcp=0),encap(eth_type(0x0800),ipv4(tos=0/0x3,frag=no)),
packets:5020, bytes:433020, used:0.010s,
actions:pop_vlan,push_vlan(vid=103,pcp=0),clone(tnl_push(tnl_port(6),header(size=50,type=4,eth(dst=00:00:5e:00:01:01,src=66:45:0b:3f:d4:4a,dl_type=0x0800),ipv4(src=10.224.1.1,dst=10.224.2.1,proto=17,tos=0,ttl=64,frag=0x4000),udp(src=0,dst=4789,csum=0x0),vxlan(flags=0x8000000,vni=0x164)),out_port(1)),2)
> >
recirc_id(0),in_port(4),packet_type(ns=0,id=0),eth(src=fa:16:3e:ee:75:a8,dst=16:58:49:ef:1c:49),eth_type(0x0806),arp(sip=10.128.2.1,tip=10.128.1.1,op=1/0xff),
packets:0, bytes:0, used:never, actions:3
> >
recirc_id(0),in_port(4),packet_type(ns=0,id=0),eth(dst=16:58:49:ef:1c:49/01:00:00:00:00:00),eth_type(0x8847),mpls(label=3073/0xfffff,tc=0/0,ttl=64/0x0,bos=0/1,label=589825/0xfffff,tc=0/7,ttl=64/0xff,bos=1/1),
packets:5020, bytes:543460, used:0.010s,
actions:pop_eth,pop_mpls(eth_type=0x8847),pop_mpls(eth_type=0x6558),set(eth(dst=00:00:00:00:00:00/01:00:00:00:00:00)),recirc(0x16)
> >
recirc_id(0),in_port(3),packet_type(ns=0,id=0),eth(src=16:58:49:ef:1c:49,dst=fa:16:3e:ee:75:a8),eth_type(0x0806),
packets:0, bytes:0, used:never, actions:4
> >
> >
> > # ovs-ofctl dump-flows br_mpls -O Openflow15
> > cookie=0x0, duration=5936.315s, table=0, n_packets=28, n_bytes=2424,
idle_age=893, priority=5000,ipv6,in_port=P2 actions=drop
> > cookie=0x0, duration=5936.277s, table=0, n_packets=150, n_bytes=8400,
idle_age=19, priority=5000,arp,in_port=P2 actions=NORMAL
> > cookie=0x0, duration=5932.412s, table=0, n_packets=51937, n_bytes=5659956,
idle_age=0, priority=25,mpls,in_port=P2 actions=resubmit(,50)
> > cookie=0x0, duration=5936.239s, table=0, n_packets=198, n_bytes=11088,
idle_age=1, priority=4999,in_port=P2,dl_dst=01:00:00:00:00:00/01:00:00:00:00:00
actions=drop
> > cookie=0x210000000000000b, duration=5932.142s, table=0, n_packets=0,
n_bytes=0, idle_age=5932, priority=15,in_port=v00789m00065789,dl_vlan=104
actions=set_field:4300->vlan_vid,resubmit(,20)
> > cookie=0x210000000000000e, duration=5931.796s, table=0, n_packets=239,
n_bytes=360910, idle_age=5894, priority=15,in_port=v00356m00065537,dl_vlan=103
actions=set_field:4299->vlan_vid,resubmit(,20)
> > cookie=0x0, duration=5932.369s, table=0, n_packets=0, n_bytes=0,
idle_age=5932, priority=5,in_port=P2 actions=NORMAL
> > cookie=0x0, duration=5936.200s, table=0, n_packets=157, n_bytes=7026,
idle_age=19, priority=0 actions=NORMAL
> > cookie=0x10000000000000b, duration=5932.098s, table=20, n_packets=0, n_bytes=0,
idle_age=5932, priority=15,dl_vlan=204
actions=encap(mpls(ether_type=34887)),set_field:65789->mpls_label,encap(mpls(ether_type=34887)),set_field:2049->mpls_label,encap(ethernet),resubmit(,30)
> > cookie=0x10000000000000e, duration=5931.758s, table=20, n_packets=239,
n_bytes=360910, idle_age=5894, priority=15,dl_vlan=203
actions=encap(mpls(ether_type=34887)),set_field:65537->mpls_label,encap(mpls(ether_type=34887)),set_field:2049->mpls_label,encap(ethernet),resubmit(,30)
> > cookie=0x1000a0000000000, duration=5932.681s, table=30, n_packets=239,
n_bytes=360910, idle_age=5894, priority=15,mpls,mpls_label=2049
actions=set_field:fa:16:3e:b2:3b:0f->eth_src,set_field:fa:16:3e:ee:75:a8->eth_dst,output:P2
> > cookie=0x0, duration=5932.322s, table=50, n_packets=51937, n_bytes=5659956,
idle_age=0, priority=15 actions=resubmit(,60)
> > cookie=0x41000a0000000000, duration=5932.645s, table=60, n_packets=51937,
n_bytes=5659956, idle_age=0, priority=15,mpls,mpls_label=3073
actions=decap(),decap(packet_type(ns=1,type=0x8847)),decap(packet_type(ns=0,type=0)),resubmit(,70)
> > cookie=0x610000000000000b, duration=5932.003s, table=70, n_packets=0,
n_bytes=0, idle_age=5932, priority=15,dl_vlan=204
actions=set_field:4200->vlan_vid,output:v00789m00065789
> > cookie=0x610000000000000e, duration=5931.674s, table=70, n_packets=51937,
n_bytes=4517342, idle_age=0, priority=15,dl_vlan=203
actions=set_field:4199->vlan_vid,output:v00356m00065537
> >
> >
> > Any help will be appreciated. Also please let me know if more context or
information is required. Thank you.
> >
> >
> > Regards,
> > Rohit Kumar
> >
> >
> > This electronic message and any files transmitted with it contains
information from ST Engineering iDirect, which may be privileged, proprietary and/or
confidential. It is intended solely for the use of the individual or entity to whom
they are addressed. If you are not the original recipient or the person responsible
for delivering the email to the intended recipient, be advised that you have received
this email in error, and that any use, dissemination, forwarding, printing, or
copying of this email is strictly prohibited. If you received this email in error,
please delete it and immediately notify the sender.
> > _______________________________________________
> > dev mailing list
> > [email protected]<mailto:[email protected]>
> >
https://protect2.fireeye.com/v1/url?k=31323334-501d2dca-fe9b10f7-454455534531-6280e9950f59d063&q=1&e=b2f3faf8-5e93-4c9b-8505-0ccd31fa22be&u=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev
This electronic message and any files transmitted with it contains information
from ST Engineering iDirect, which may be privileged, proprietary and/or
confidential. It is intended solely for the use of the individual or entity to
whom they are addressed. If you are not the original recipient or the person
responsible for delivering the email to the intended recipient, be advised that
you have received this email in error, and that any use, dissemination,
forwarding, printing, or copying of this email is strictly prohibited. If you
received this email in error, please delete it and immediately notify the
sender.
This electronic message and any files transmitted with it contains information
from ST Engineering iDirect, which may be privileged, proprietary and/or
confidential. It is intended solely for the use of the individual or entity to
whom they are addressed. If you are not the original recipient or the person
responsible for delivering the email to the intended recipient, be advised that
you have received this email in error, and that any use, dissemination,
forwarding, printing, or copying of this email is strictly prohibited. If you
received this email in error, please delete it and immediately notify the
sender.
_______________________________________________
discuss mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
