Fixed, thank you. On 5/26/06, Vincent Fleming <[EMAIL PROTECTED]> wrote:
I've ported owfs-2.3p7 to OpenWRT Kamikaze (the latest and greatest), and have had some problems during the port. I turned off the MT to try and isolate the problems, and discovered the syntax error.I've since hunted down my problem - it was the 2.6 kernel USB that is broken; the 2.4 kernel USB works fine. I'm using a USB 1-wire and a bunch of gadgets from hobby-boards.com on an NetGear WGT634u. All works nicely now, with the exception of all the owfs stuff (owfs, owhttpd) I've tried so far seem to spawn 3-6 processes, and "df" causes owfs to die. I'll have to track those down... ;-) It seems there might be a problem with daemon() in uClibc; I haven't even looked at the "df" problem yet. Oh - checking my patches, I forgot another syntax error I received a while back... --disable-cache makes a syntax error in ow_cache.c visible: --- owfs-2.3p7/module/owlib/src/c/ow_cache.c.old 2006-05-21 16:31:51.105832633 -0400 +++ owfs-2.3p7/module/owlib/src/c/ow_cache.c 2006-05-21 16:32:07.076586060 -0400 @@ -671,7 +671,7 @@ { return 1; } int Cache_Del_Internal( const struct internal_prop * ip, const struct parsedname * pn ) { return 1; } -int Cache_Add_Dir( const BYTE * snlist, const size_t devices, const struct parsedname * pn ) { +int Cache_Add_Dir( const BYTE * snlist, const size_t devices, const struct parsedname * pn ) { return 1; } int Cache_Add_Device( const int bus_nr, const struct parsedname * pn ) { return 1; } Note the extraneous "{" on the Cache_Add_Dir() definition. Cheers, Vince -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Paul Alfille Sent: Friday, May 26, 2006 9:07 AM To: [email protected] Subject: Re: [Owfs-developers] Syntax error in ow_net.c Thank you. I've a question for you. Why do you find multithreading undesirable. I originally though it wouldn't work on embedded appliances, but Christian has proven me wrong. Should I keep the option available? Paul Alfille On 5/26/06, Vincent Fleming <[EMAIL PROTECTED]> wrote: > > > > > FYI all; > > > > When configured/compiled with -disable-mt (no multithread), there is a > syntax error in owfs-2.3p7/module/owlib/src/c/ow_net.c at line 372. > > > > There's an extraneous ")" near the end of the line. > > > > Here's the DIFF: > > > > --- owfs-2.3p7/module/owlib/src/c/ow_net.c.orig 2006-05-26 > 08:35:54.383226164 -0400 > > +++ owfs-2.3p7/module/owlib/src/c/ow_net.c 2006-05-26 > 08:36:02.901033493 -0400 > > @@ -369,7 +369,7 @@ > > Exit(1) ; > > } else { > > while (1) { > > - int acceptfd=accept(outdevice->fd,NULL,NULL)) > ; > > + int acceptfd=accept(outdevice->fd,NULL,NULL) ; > > if ( acceptfd < 0 ) { > > ERROR_CONNECT("Trouble with accept, will reloop\n") ; > > } else { > > > > > > Regards, > > > > Vince ------------------------------------------------------- All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more http://sel.as-us.falkag.net/sel?cmd=k&kid7521&bid$8729&dat1642 _______________________________________________ Owfs-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/owfs-developers ------------------------------------------------------- All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more http://sel.as-us.falkag.net/sel?cmdlnk&kid7521&bid$8729&dat1642 _______________________________________________ Owfs-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/owfs-developers
------------------------------------------------------- All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more http://sel.as-us.falkag.net/sel?cmd=lnk&kid7521&bid$8729&dat1642 _______________________________________________ Owfs-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/owfs-developers
