This is great. Thank you. On Wed, Oct 6, 2010 at 3:56 AM, Der Tiger <[email protected]> wrote: > Hi Paul, > > Since at least 2.7p6 there has been a bug causing all three buttons of > the Hobbyboards LCD module (using a DS2408) to malfunction. This is due > to the fact, that the three lowest bits of the port register are set to > 0 during initialization of the display module, turning the output > transistors on and by that taking the sensing voltage away from the > buttons. It is necessary to mask those bits as suggested in the patch below. > > --- owfs-2.8p2/module/owlib/src/c/ow_2408-p2.c 2010-08-08 > 18:17:13.000000000 +0200 > +++ owfs-2.8p2/module/owlib/src/c/ow_2408.c 2010-10-04 > 10:40:41.887816999 +0200 > @@ -135,2 +141,3 @@ > -#define NIBBLE_ONE(x) ((x)&0xF0) > -#define NIBBLE_TWO(x) (((x)<<4)&0xF0) > +#define LCD_BUTTON_MASK 0x07 > +#define NIBBLE_ONE(x) (((x)&0xF0)|LCD_BUTTON_MASK) > +#define NIBBLE_TWO(x) ((((x)<<4)&0xF0)|LCD_BUTTON_MASK) > @@ -387 +392 @@ > - BYTE start[] = { LCD_COMMAND_ATTENTION, }; > + BYTE start[] = { NIBBLE_ONE(LCD_COMMAND_ATTENTION), }; > @@ -389,3 +394,3 @@ > - LCD_COMMAND_ATTENTION, > - LCD_COMMAND_ATTENTION, > - LCD_COMMAND_4_BIT, > + NIBBLE_ONE(LCD_COMMAND_ATTENTION), > + NIBBLE_ONE(LCD_COMMAND_ATTENTION), > + NIBBLE_ONE(LCD_COMMAND_4_BIT), > > The patch has been successfully tested. To ensure proper function in > future releases of OWFS, please, consider patching the source as described. > > This issue is related to: > http://sourceforge.net/mailarchive/message.php?msg_id=9a37aeaf0709121729t65cd87dahc0d79a41e2f3249c%40mail.gmail.com > http://sourceforge.net/mailarchive/message.php?msg_id=9a37aeaf0812021119q1365c262n584ed44ef25b3876%40mail.gmail.com > > Thanks for your hard work! > > Best Regards, > > -- > Klaus, the Tiger > CoDev OPT_OW > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb > _______________________________________________ > Owfs-developers mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/owfs-developers >
------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ Owfs-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/owfs-developers
