On Wed, Mar 23, 2011 at 6:57 AM, Vincent Danjean <[email protected]> wrote:
>  Hi Paul,
>
>  I'm looking at the patches from my Debian package that have been applied
> upstream. I've a few comments:
> * [Vincent Danjean's debian patch #2] I think this patch should be reversed or
>  garded in order to only apply when building a Debian package. For a
>  local install of TCL, your way to find the install directory is better.

Ok, I commented out. How would I make it Debian-only in the configure.ac file?

> * [Vincent Danjean's Debian patch 4/7] there is a typo when you applied the
>  patch: it is "INSTALLDIRS=vendor" and not "INSTALLDIRS-vendor"
> * [Debian change] I think this patch can be applied for all linux 
> distributions.
>  Unless you have conditional code compilation in the library, if the debian
>  owcapi library does not use any libusb symbols, it should be the same for
>  all other linux distributions (and perhaps even for cygwin but I do not
>  know enough about linking on cygwin to be sure)

Fixed, thank you.

>
>  Regards,
>    Vincent
>

------------------------------------------------------------------------------
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software 
be a part of the solution? Download the Intel(R) Manageability Checker 
today! http://p.sf.net/sfu/intel-dev2devmar
_______________________________________________
Owfs-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/owfs-developers

Reply via email to