Fantastic work!
I applied your patches, and took the opportunity to clean up some of the
code. I also found some more places based on your pattern.
The DS9097 should be correct, it's operating on a bit stream rather than
fields interpreted as integers.
All this is in the CVS now, and will be included in the next release.
Of course, there may be some more endian errors lurking. bit manipulation
is pretty pervasive in 1-wire work. Fortunately much of it is done as bit
streams rather than numbers.
On Sat, Mar 1, 2014 at 6:07 PM, Robin Gilks <[email protected]> wrote:
> > That's very helpful. The functions should be correct for data on the
> slave
> > (it's little endian). If we cast host integers to char and use these
> > functions would be incorrect.
>
> Its been raining more than expected for this time of year so I've been
> able to take my irrigation system offline for long enough to try a quick
> hack. Note that this is a proof of concept, not a real fix.
>
> I've added extra functions into util.c for UT_setbit_U and UT_getbit_U to
> deal with UINTs rather than try and treat them as an array of bytes. I've
> hacked up the modules that I think will have a bearing on handling
> aggregate properties on a device and it works!! I can use PIO.A and PIO.B
> of a ds2413 on big endian:)
>
> There are a lot of modules that I think will require extra work (e.g.
> ow_ds9097u.c) and the same problem arises with UT_get2bit() and
> UT_set2bit() functions not being endian safe.
>
> Cheers
>
> --
> Robin Gilks
>
>
> ------------------------------------------------------------------------------
> Flow-based real-time traffic analytics software. Cisco certified tool.
> Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
> Customize your own dashboards, set traffic alerts and generate reports.
> Network behavioral analysis & security monitoring. All-in-one tool.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
> _______________________________________________
> Owfs-developers mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/owfs-developers
>
>
------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
Owfs-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/owfs-developers
