| Maybe a better solution is
systemdsystemunit_DATA = \ owfs.service \ owftpd.service \ owhttpd.service \ owserver.service \ owserver.socket CLEANFILES = $(systemdsystemunit_DATA) EXTRA_DIST = \ owfs.service.in \ owftpd.service.in \ owhttpd.service.in \ owserver.service.in \ owserver.socket.in
do_subst = sed -e 's,[@]bindir[@],$(bindir),g'
% :: %.in $(do_subst) < $(srcdir)/$< > $@
$(systemdsystemunit_DATA): Makefile
???
Here again my patches against commit 95aaca3a1b2c933839d46486daecbb320472ac92
|
0001-add-check-for-librt-mq_getattr-function-and-delete-c.patch
Description: Binary data
0002-new-makefile.am.patch
Description: Binary data
A final comment:
the autoconf manual states that the manual solution (generating the src/scripts/systemd/owfs.service etc files at 'make time' instead of 'configure time') is the correct and robust solutions since it should be possible to override all variables (bindir, prefix, etc.) during the invocation of make... see http://www.gnu.org/software/automake/manual/html_node/Scripts.html
The use of @BINDIR@ is a non standard feature embedded in configure.ac with commits 4631430a (Christian Magnusson 2008-01-28 22:19:44 +0000 809) 94fd6957 (Paul Alfille 2008-12-21 23:46:42 +0000 810) which apparently is no more used (and may be should not be used.)
Sorry for all the noise I generated...
still I think that "AC_CHECK_LIB([rt],[mq_getattr])" is necessary to properly compile under linux. The whole thing about the Makefile.am should be analysed more closely. The current state is not satisfactory, though, since many make commands (like "make dist" and "make clean" or "make distclean") do not work as expected.
S. It should be @BINDIR@ instead of @bindir@...please find enclosed the patches that should implement the proposed modifications...Stefano <0001-add-check-for-librt-mq_getattr-function-and-clean-ma.patch><0002-corrected-autoconf-var.patch>
On Tue, Aug 12, 2014 at 04:07:47PM +0200, Stefano Miccoli wrote:
Other problems: I do not understand the src/scripts/systemd/Makefile.am
logic: it simply mimics (in an incomplete and error prone way) the standard
autoconf/automake semantics.
I agree that it may look redundant. I've tried to use automake directly,
(based on snippets in "man 7 daemon"), but it expanded @bindir@ to
${exec_prefix}, resulting in:
ExecStart=${exec_prefix}/owserver
in owserver.service, which is blatantly wrong.
An empty Makefile.am will do the same job provided
that
src/scripts/systemd/owfs.service
src/scripts/systemd/owftpd.service
src/scripts/systemd/owhttpd.service
src/scripts/systemd/owserver.service
src/scripts/systemd/owserver.socket
are listed among the AC_CONFIG_FILES in configure.ac.
I'm not a master of autotools, can you provide this comment in patch form? ;)
--
Tomasz Torcz To co nierealne -- tutaj jest normalne.
xmpp: zdzich...@chrome.pl Ziomale na życie mają tu patenty specjalne.
------------------------------------------------------------------------------
_______________________________________________
Owfs-developers mailing list
Owfs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/owfs-developers
_______________________________________________
Owfs-developers mailing list
Owfs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/owfs-developers
_______________________________________________
Owfs-developers mailing list
Owfs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/owfs-developers
|
------------------------------------------------------------------------------
_______________________________________________
Owfs-developers mailing list
Owfs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/owfs-developers
