Commit 8d3d37b1b90 introduced in the makefiles a lot of stuff which is 
developer related and not portable: rules for executing lint (using a windows 
executable via wine) hardcoded local directories and so on.

IMHO the makefile system should strictly adhere to GNU automake semantics and 
standards (see 
http://www.gnu.org/prep/standards/standards.html#Standard-Targets ) and not be 
(ab)used for maintainer related tasks, like lint checks, cleaning up editor 
backups, and so on.

In this very special case, the first line of src/tools/lint/lint.mk is

DOS_OWFSROOT ?= C:/projects/softhub/

why should one desire to distribute in the tarball such settings, even in the 
case of a cygwin system? It seems that by mistake files meant for local use 
made their way into the main git archive.

And sorry if I ask again: please do tag the releases on git (as simple as 'tag 
-a v2.9p6') to make tracking of changes easier.

Stefano


PS:

I maintain a "personal" topic-branch darwin (you can find it at 
https://github.com/miccoli/owfs-darwin ) that compiles on OSX. It's not ready 
for general use, but I'm trying to keeping it up to date with upstream branch 
master. (I'm stuck in merging 8d3d37b1b90 because it introduced too many 
changes in a single commit to be handled in a semi-automated procedure, but I 
hope to keep pace with the master branch.)

In parallel I have a a "darwin-clean" branch In which I cleaned up all makefile 
stuff to my personal taste. In that branch you can "make distcheck" to verify 
that the tarball is self-contained before a release. (This requires a lot of 
changes, since the assumption is that a VPATH build is possible, see 
http://www.gnu.org/software/automake/manual/html_node/VPATH-Builds.html and 
http://www.gnu.org/software/automake/manual/html_node/Checking-the-Distribution.html#Checking-the-Distribution
 )
'make distcheck' semantics are very strict, but at the end you can be confident 
to have a working tarball.

Again, both branches are not ready for general use, but some of the ideas in 
darwin-clean could be considered for inclusion in the master branch.



On 08 Oct 2014, at 08:37, Johan Ström <jo...@stromnet.se> wrote:

> Nice! Got some problems building the tarball though...
> 
> Making all in owlib
> --- all-recursive ---
> Making all in src
> --- all-recursive ---
> Making all in c
> make[5]: 
> "/wrkdirs/usr/ports/comms/owfs/work/owfs-2.9p6/module/owlib/src/c/Makefile" 
> line 1274: Cannot open 
> /wrkdirs/usr/ports/comms/owfs/work/owfs-2.9p6/src/tools/lint/lint.mk
> make[5]: Fatal errors encountered -- cannot continue
> make[5]: stopped in 
> /wrkdirs/usr/ports/comms/owfs/work/owfs-2.9p6/module/owlib/src/c
> *** [all-recursive] Error code 1
> 
> src/ exists in git, but not in the tarball, it seems?
> Since this "lint" thing seems to require cygwin, I guess the 'include 
> $(abs_top_srcdir)/src/tools/lint/lint.mk' line should be inside the if 
> HAVE_CYGWIN check?
> 
> 
> /Johan
> 
> On 08/10/14 03:59, Paul Alfille wrote:
>> OWFS 2.9p6
>> Release Notes
>> 
>> Oct 7, 2014
>> 
>> One Wire File System
>> www.owfs.org
>> 
>> New Features
>> 1. HobbyBoards Masterhub
>>  A. New 4-port hub
>>  B. USB suport
>>  C. Ethernet not yet implemented
>>  D. Autodiscovery not yet implemented
>> 2. New HobbyBoards Sensors
>>  A. Updated Moisture Meter
>>  B. Humidity
>>  C. Barometer
>> 3. Improved systemd support -- Tomasz Torcz
>> 
>> Fixes
>> 1. Mutex errors and checking, including read-write lock error -- Christian 
>> Magnusson
>> 2. Longer timeput needed for FTDI serial adapters -- Johan Ström
>> 3. FreeBSD fixes -- Johan Ström
>> 4. mucl C library support -- der_tiger and Szabocls Nagy
>> 5. Numerous fixes found by Coverity analysis
>> 6. Configuration script fixes from Christian Magnusson and der_tiger 
>> 7. owcapi bug in OW_present -- Valery Grusdev
>> 8. ownet payload size off by one -- Hans-Frieder Vogt
>> 9. OSX mutex error -- Stefano Miccoli
>> 10. Show HobbyBoard device version in decimal rather than hex
>> 11. MAX31850 Termocouple correction -- Paul Panish
>> 12. Endiaan fix for DS2408 -- Johan Ström
>> 13. DS18B20 resolution fix -- Johan Ström
>> 14. Python trouble with verion from CVS -- Johan Ström
>> 
>> -------------------
>> 
>> I hope I didn't miss anyone's contribution.
>> 
>> Next will be 
>> 1. Better auto-detection (for some USB devices
>> 2. Tuning FTDI adapter parameters
>> 3. Finishing Masterhub support
>> 4. Fixing and improving external device support
>> 
>> 
>> 
>> ------------------------------------------------------------------------------
>> Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
>> Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
>> Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
>> Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
>> http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
>> 
>> 
>> _______________________________________________
>> Owfs-developers mailing list
>> Owfs-developers@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/owfs-developers
> 
> ------------------------------------------------------------------------------
> Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
> Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
> Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
> Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
> http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk_______________________________________________
> Owfs-developers mailing list
> Owfs-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/owfs-developers

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Owfs-developers mailing list
Owfs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/owfs-developers

Reply via email to