On 27/01/16 23:45, Stefano Miccoli wrote:
> Minor glitch on module/owlib/src/c/ow_ftdi.c:
>
> here you use MIN and MAX macros, which are defined in <sys/param.h>.
> Don’t ask me why, but this file is not included in linux:
>
> — form ow.h:
>
> #ifdef HAVE_SYS_TYPES_H
> #ifdef __FreeBSD__
> #include <sys/param.h>
> #endif /* __FreeBSD__ */
> #include <sys/types.h> /* for stat */
> #endif /*
> HAVE_SYS_TYPES_H */
>
> —
>
> Therefore your branch won’t compile… (or better won’t link.). MIN/MAX
> macros are frowned upon, so maybe if you positively like them you
> should define them in ow_ftdi.c or better use an inline function…
> like this page suggests:
> https://dustri.org/b/min-and-max-macro-considered-harmful.html
>
> Please find a patch enclosed…
>
Ah, thanks for pointing out! A patch has been pushed, but I placed
min/max in ow_minmax.h instead for reusability (maybe it should be
ow_min/ow_max instead?).
Johan
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Owfs-developers mailing list
Owfs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/owfs-developers
