On Monday 21 Mar 2016 22:27:21 Johan Ström wrote: > On 21/03/16 20:59, Andy Carter wrote:
> >> Now build, and see if this works. > > > > Almost, I now have > > aaa > > bbb > > ccc > > dddd|||||||||| > > > > that's 5 double pipes > > > > owwrite "/FF.870900000100/line20.ALL" aaa,bbb,ccc,ddd > > > > as before > > > > Log at https://gist.github.com/anonymous/0d642c671f21dd42bd78 > > I'm quite sure the error is at ow_parseinput.c line 462: > > // shorten the buffer length by the comma and discarded chars I wondered if it was including the commas but the doubled last char is puzzling too. > end -= entry_length - allowed_length - 1 ; I'll try that in the morning > The purpose is to move the endpointer, but the logic is wrong, and the > last element length (line 441) is wrongly calculated base on 'end'. > My currently tired brain suggests 'end -= entry_length - 1;', but I > might be wrong.. And I do not have any device at all which accepts an > aggregate ascii write. > > Do we have any unit-tests at all? I'm sure this one can wait until someone else gets a chance to look at it. I had a couple of instances where the double-pipes were replaced with 0 chars but not been able to reproduce it reliably. I think I've found another too :( Both owwrite "/FF.870900000100/line20.0" -xxxx owwrite "/FF.870900000100/line20.ALL" -aaa,bbb,ccc,ddd display nothing at all, with/without quotes however x-xxx displays fine perl version of those same two lines displays expected text with - char Other shifted chars seem to be OK but not checked all yet - I'll try a wheezy 2.8p15 and maybe more tomorrow to see if that does the same. Thanks for help so far Andy ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 _______________________________________________ Owfs-developers mailing list Owfs-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/owfs-developers
