On Thu, 2018-11-15 at 11:19 +0100, Stefano Miccoli via Owfs-developers wrote: > > On 15 Nov 2018, at 08:27, Alastair D'Silva <alast...@d-silva.org> > > wrote: > > > > > > One question, my code has C99isms, which are fine for modern > > compilers as they default to C99. Older compilers default to C90. > > > > I can fix this in 2 ways: > > Easy way: add std=c99 to CFLAGS to force C99 mode > > Hard(er) way: Remove C99isms from the code. It's not that hard, but > > it will result in some vars getting a larger scope than they need. > > > > I would prefer updating the coding style to C99. Sooner or later the > OWFS codebase should be modernised, so it makes not sense, IMHO, to > hold back C99 for new contributions. > > Stefano > >
So far, that's 3 votes (+myself & 1 on Github) for & none against. I'll enable C99 in that commit, and I'll start another dev branch where I enable -Wall -Wextra & start addressing any warnings that I see. -- Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva Twitter: @EvilDeece blog: http://alastair.d-silva.org _______________________________________________ Owfs-developers mailing list Owfs-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/owfs-developers
