----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101654/#review3960 -----------------------------------------------------------
Ship it! Having error handeling here is good to have indeed. Patch looks good to me. - Robin On June 17, 2011, 2:15 p.m., Kamil Domański wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101654/ > ----------------------------------------------------------- > > (Updated June 17, 2011, 2:15 p.m.) > > > Review request for ownCloud. > > > Summary > ------- > > This patch causes the apps page to inform the user about any failure to > connect the apps repositoty, instead of spitting PHP warnings. > > > Diffs > ----- > > admin/apps.php 7ce3f4c > admin/templates/app_noconn.php PRE-CREATION > lib/ocsclient.php a3c4659 > > Diff: http://git.reviewboard.kde.org/r/101654/diff > > > Testing > ------- > > Works fine for me. Shows apps repo if connected to the internet, and says > "Cannot connect to apps repository" when I unplug my box. > > > Thanks, > > Kamil > >
_______________________________________________ Owncloud mailing list [email protected] https://mail.kde.org/mailman/listinfo/owncloud
