Hi, I have created a patch for bookmarks section. It shows the bookmark entry in the list immediately after insertion, And hides it after deletion; using some javascript code.
I do have write access to KDE repos, Is it ok to send a patch for each fix, or I should do fixes in a separate branch and request for merging with master? In fact, It is good to have contribution policies documented.
From 262a652710228e6bc1fc9689267375854a5bec22 Mon Sep 17 00:00:00 2001 From: Golnaz Nilieh <[email protected]> Date: Fri, 19 Aug 2011 13:30:05 +0430 Subject: [PATCH] Show new bookmark in the list after insertion, And hide it after deletion. --- apps/bookmarks/js/bookmarks.js | 23 ++++++++++++++++++++--- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/apps/bookmarks/js/bookmarks.js b/apps/bookmarks/js/bookmarks.js index de747ae..c974f40 100644 --- a/apps/bookmarks/js/bookmarks.js +++ b/apps/bookmarks/js/bookmarks.js @@ -37,18 +37,35 @@ function getBookmarks() { } function addBookmark(event) { + var url = $('#bookmark_add_url').val() + var title = $('#bookmark_add_title').val() + var description = $('#bookmark_add_description').val() + var tags = $('#bookmark_add_tags').val() $.ajax({ url: 'ajax/addBookmark.php', - data: "url=" + encodeURI($('#bookmark_add_url').val()) + "&title=" + encodeURI($('#bookmark_add_title').val()) + "&description=" + encodeURI($('#bookmark_add_description').val()) + "&tags=" + encodeURI($('#bookmark_add_tags').val()), - success: function(data){ $('.bookmarks_add').slideToggle(); $('.bookmarks_add').children('p').children('.bookmarks_input').val(''); } + data: "url=" + encodeURI(url) + "&title=" + encodeURI(title) + "&description=" + encodeURI(description) + "&tags=" + encodeURI(tags), + success: function(data){ + $('.bookmarks_add').slideToggle(); + $('.bookmarks_add').children('p').children('.bookmarks_input').val(''); + $('.bookmarks_list').prepend( + "<div class=\"bookmark_single\">" + + "<p class=\"bookmark_title\"><a href=\"" + url + "\" target=\"_new\" class=\"bookmark_link\">" + title + "</a></p>" + + "<p class=\"bookmark_url\">" + url + "</p>" + + "<p class=\"bookmark_description\">" + description + "</p>" + + "<p>" + tags + "</p>" + + "<p class=\"bookmark_actions\"><span class=\"bookmark_delete\">Delete</span></p>" + + "</div>" + ); + } }); } function delBookmark(event) { + var record = $(this).parent().parent() $.ajax({ url: 'ajax/delBookmark.php', data: "url=" + encodeURI($(this).parent().parent().children('.bookmark_url:first').text()), - success: function(data){ alert('deleted!'); } + success: function(data){ record.animate({ opacity: "hide" }, "fast"); } }); } -- 1.7.4.1
_______________________________________________ Owncloud mailing list [email protected] https://mail.kde.org/mailman/listinfo/owncloud
