Re: [Owncloud] SabreDAV property namespaces (clark notation)

Fri, 20 Jul 2012 01:48:04 -0700 

On 19.07.2012 12:49, Bjoern Schiessle wrote:
Hi Björn,


I discovered a problem with the property handling on our SabreDAV
server. We are looking for the property "lastmodified" in
connector/sabre/node.php (line 154) but what we get is "{}lastmodified".

After digging into SabreDAV I found out that the curly bracket are used
for the namespace (3rdparty/Sabre/DAV/XMLUtil.php (line 40)) but in the
case of "lastmodified" there is no namespace and therefore it returns
"{}lastmodified".

I'm not sure how to deal with it. Is this something which should be
handled in SabreDAV or should we just filter out the brackets in
ownCloud?
I think the problem is two fold: The client does not send the correct namespace for the lastmodified property (I fixed that to use the DAV: namespace) AND the server code does not consider the namespace at all. 
However, there are still "wrong" clients out there for the next time.
Thus I suggest the attached patch for a fix. Works fine here for all conditions yet has the problem that the namespace is not looked at. 

Opinions?

Klaas

Attachment: fix_reupload.dif
Description: video/dv

_______________________________________________
Owncloud mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/owncloud

Reply via email to