First of, cheers and ty for using the framework :)

I must admit defeat :D

They say there are only two hard things in software development:

* naming
* caching

It seems I failed in naming: You are the second person who turns of CSRF checks by copying(?) the main controller method comments. Was this your intention? If not i need to fix the comments in the apptemplate.

Some small things:
* you can access POST variables by using $this->params('key') instead of $_POST['key'] in controllers. This helps you to write unittests ;)
* theres a $this->renderJSON() shortcut for returning JSON
* for a simple response, just use the Response object instead of TextResponse

Other than that I'm impressed :) I normally find a lot things to nag on but this is really good code ;)

On 03/13/2013 08:44 PM, Qingping Hou wrote:
Hi all,

I finshed the first version of Prey control panel app for ownCloud:
https://github.com/houqp/ownPrey

It's a reimplementation of following control panel:
https://github.com/prey/prey-standalone-control-panel

It's using appframework, so you have to enable the framework first
before using it.

After I went through their node js code, I find that the ruby one is
too simple and lacks some of the feature. They are even a little bit
different in terms of communication protocol. Since Preyproject did
not release the protocol document, I will have to first study their
client code and add all the features back to my app later.

Cheers,
houqp

On Mon, Feb 25, 2013 at 11:42 AM, Qingping Hou <[email protected]> wrote:
wow, didn't expect the control panel can be written in so little code.

I will probably start working on it next week cause we are having
midterms right now ;p

will report back on this thread once I have any progress or other questions.

thanks to both of you for the help :)

On Mon, Feb 25, 2013 at 11:33 AM, Thomas Müller <[email protected]> wrote:
That code is damn-fuxxing easy!

Go go go!

In case you need support in reading this sinatra/ruby/rack stuff: ping me.

Tom


Am Montag, dem 25.02.2013 um 17:25 schrieb Alessandro Cosentino:
Hi again,

I can see an open source version of the control panel (server side) here:
https://github.com/prey/prey-standalone-control-panel

Maybe you can take inspiration from that?

Alessandro

(thanks for forking the discussion to a new thread)


On Mon, Feb 25, 2013 at 4:54 PM, Qingping Hou <[email protected]> wrote:
Prey is an open source software that does what you want: http://preyproject.com/
I remember there was a discussion on this ml for an ownCloud app that
integrates with Prey, see
http://mail.kde.org/pipermail/owncloud/2012-March/002656.html
(we can continue the discussion in another thread if you want)
Thanks for the suggestions from Alessandr :)

I just checked Prey, seems that they only open sourced the client
side? If we want to integrate it into ownCloud, we need to write an
app to turn ownCloud into a Prey server right?


Cheers,
houqp
_______________________________________________
Owncloud mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/owncloud
_______________________________________________
Owncloud mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/owncloud
_______________________________________________
Owncloud mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/owncloud
_______________________________________________
Owncloud mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/owncloud

_______________________________________________
Owncloud mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/owncloud

Reply via email to