On Mar 14, 2013, at 7:09 PM, Georg Ehrke <[email protected]> wrote:
> > On Mar 14, 2013, at 6:40 PM, Jan-Christoph Borchardt <[email protected]> > wrote: > >> It’s good to have more review going on for the apps of course and I agree >> with most of your suggestions. >> >> Creating a central repo for the apps and centralizing all testing is the >> wrong solution though I think. > We need a centralized repo for united tests * unit tests (damn autocorrect) > and automated penetration testing. At least, it makes it easier to run these > tests. >> Who should do the testing? > Mr. Jenkins >> We have few people as it is, and we need to work on other things. 3rd party >> devs should happily be able to develop on their own turf and with their own >> methods. >> >> Reviewing boils down to: Install the app, click around, look into the >> console. Does it work? Are there any errors? Is it fun to use? >> >> That’s just something people need to do, and at the end great apps get the >> »Recommended« stamp, and all apps get feedback about what was good and bad >> and what to improve. No big scaffolding needed and especially not another >> centralized repo as dump for all apps. >> >> >> >> >> >> On Thu, Mar 14, 2013 at 6:26 PM, Georg Ehrke <[email protected]> wrote: >>> Hi all, >>> I would like to start a discussion about our apps review process. >>> There already is a review process for apps on apps.ownCloud.com, but imho >>> it's not working as it's supposed to be. >>> There are no discussions about new / updated apps and it's just not working >>> out. >>> >>> My proposal: >>> We have to make it easier for reviewers to review apps. >>> We should create an apps.ownCloud.com repo on GitHub. >>> >>> My approach for a new workflow: >>> If one submits a new / updated app, it will be pushed to this repository. >>> This will enable reviewers to simply take a look at the diff of an updated >>> app and discuss changes directly on GitHub. >>> Reviewers will be able to give :+1: or :-1: to show if they would like to >>> approve or refuse the update. >>> We will also be able to run unit tests and automated penetration testing. >>> >>> Update apps guidelines: >>> - only one bug fix / feature update may be submitted a day >>> - I really appreciate the afford developers put in their apps, but >>> all reviewers are volunteers, who don't have time to approve the same app >>> five times a day >>> - this rule doesn't apply if the update contains security fixes. >>> >>> I am not sure, if we should add these rules as well. Feedback please. >>> >>> - the app must use the ownCloud Public API >>> - it may not come without unit tests >>> >>> Other minor changes to apps.ownCloud.com: >>> If an app was not approved yet, one should be able to download the old >>> version(, except there is a known security issue). >>> >>> Cheers >>> Georg Ehrke >>> _______________________________________________ >>> Owncloud mailing list >>> [email protected] >>> https://mail.kde.org/mailman/listinfo/owncloud >> >> _______________________________________________ >> Owncloud mailing list >> [email protected] >> https://mail.kde.org/mailman/listinfo/owncloud > _______________________________________________ > Owncloud mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/owncloud
_______________________________________________ Owncloud mailing list [email protected] https://mail.kde.org/mailman/listinfo/owncloud
