Perhaps you are right, although I'm not quite getting yet why the first pull request is nessecary. Offcource I already have read the manual, you provided a link to here. In the manual is also written about AngularJS, which imo is bad to use for templating. It's not fast enough, and forces users to learn another way of writing code, instead of just CSS/HTML and a small bit of JS.
I'll look into making proper bug reports/feature requests real soon, so we can *perhaps* combine efforts. Besides that, I think it's wise to move the standard ownCloud style into a theme "owncloud". This makes things easier to split design vs function through out all the apps/core and leaves us with a standard core.css file, which does not involve any colors or styling at all. Only some reset-styles to make things (more) cross-browser. This is work that could be done already and could be extended once we complete the splitting and rewriting of code. I will file a feature request for this and try to get things done. (Not very familiar with Github patches and diffs yet unfortunately). Kind regards, Stefan Op 16 mrt. 2013, om 12:02 heeft Bernhard Posselt <[email protected]> het volgende geschreven: > The whole problem is a one issue and a developer issue only: > > * seperation between view and logic in the js > > for better CSS for applications to reuse see > https://github.com/owncloud/core/pull/2275 and > http://doc.owncloud.org/server/master/developer_manual/app/appframework/css.html > > > As much as I'd like to rewrite nearly everything in core because its fked up > there has to be a proper test setup first. I think neither one of us wants to > fix have 50 new bugs because something got rewritten, as fked up as the > previous solution might have been. Also users will complain a lot since they > didnt profit from the changes and have non working software. > > Therefore please contribute to https://github.com/owncloud/acceptance-testing > first > > *AFTER* we have *ALL* the tests, we can prove that the improvements in core > and in the JS broke nothing. > > We also need to write JS unittests, see > http://doc.owncloud.org/server/master/developer_manual/app/appframework/unittesting.html#javascript > > PS: Im going to work on this together with app developers after the News app > is finished. I'll also write documentation on this. > > On 03/16/2013 11:05 AM, Stefan Nagtegaal wrote: >> Of what *exactly*would you like me to file an issue? >> - the annoying and mostly overused absolute/fixed positioning of owncloud, >> which makes theming even harder for the average user? >> - the fact that the generated HTML from the javascript files is not themable? >> - the separation of style vs function between CSS and JS? >> - the problem of having every app implement it's own (inconsistent) version >> of commonly used regions, for returning things like notifications, controls, >> content? >> >> IMO it would be *much* better and a lot cleaner if we would implement >> Google's Bootstrap for the default styling. It's easy for everybody to work >> with, gives us a solid and proven base to work on, and implements everything >> owncloud needs to give it a clean, solid and cross-browser UI. >> >> 90% of the Javascript owncloud core implements, is available in the default >> bootstrap package. >> >> I'm not completely sure what you mean. >> >> Kind regards, >> >> >> Stefan >> >> >> Op 16 mrt. 2013, om 10:36 heeft Frank Karlitschek <[email protected]> het >> volgende geschreven: >> >>> Hi Stefan, >>> >>> thanks a lot for your offer to help. That's great. >>> First of all I would suggest that you open an issue on github where you >>> describe the problem with the current implementation. The next step would >>> be then to discuss changed to improve this. >>> If we agree on a change then the next step is to implement it in a branch >>> and open a pull request. >>> >>> But first it would be good to understand what you want to do. >>> >>> Thanks a lot. >>> >>> Frank >>> >>> >>> On 16.03.2013, at 10:30, Stefan Nagtegaal <[email protected]> >>> wrote: >>> >>>> I would like to improve owncloud theming and templating, which currently >>>> isn't as good as it should/could be. >>>> Now, I would like to know what the proper and most reliable way is, of >>>> getting things committed to core? >>>> >>>> And, as a sidenote I'm not completely sure what belongs to core and what >>>> not. Owncloud seems to be distributed with a "3rdparty"-directory, which >>>> seems to be 3rd party applications and source code, although I'm not >>>> completely sure about this. >>>> The apps-directory hold quite some apps, which some of them are >>>> "internal", "3rd Party" or "Recommended". >>>> >>>> So the question is, to make patches for the proper files and apps, which >>>> applications are part of owncloud core, and which are not? >>>> >>>> And, are there any thoughts on how to make the generated HTML from the >>>> javascript files, themable/templatable? >>>> >>>> >>>> Kind regards, >>>> >>>> >>>> Stefan Nagtegaal >>>> >>>> >>>> _______________________________________________ >>>> Owncloud mailing list >>>> [email protected] >>>> https://mail.kde.org/mailman/listinfo/owncloud >>> _______________________________________________ >>> Owncloud mailing list >>> [email protected] >>> https://mail.kde.org/mailman/listinfo/owncloud >> _______________________________________________ >> Owncloud mailing list >> [email protected] >> https://mail.kde.org/mailman/listinfo/owncloud > > _______________________________________________ > Owncloud mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/owncloud
_______________________________________________ Owncloud mailing list [email protected] https://mail.kde.org/mailman/listinfo/owncloud
