This is an automated email from the ASF dual-hosted git repository.
arp pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hadoop-ozone.git
The following commit(s) were added to refs/heads/master by this push:
new 12e9a26 HDDS-4058. Wrong use of AtomicBoolean in HddsDatanodeService
(#1284)
12e9a26 is described below
commit 12e9a265679d8a49bcf679f7ceba47f882528b7e
Author: Doroszlai, Attila <[email protected]>
AuthorDate: Mon Aug 3 21:25:05 2020 +0200
HDDS-4058. Wrong use of AtomicBoolean in HddsDatanodeService (#1284)
---
.../src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java
b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java
index aee0f03..cfb22e3 100644
---
a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java
+++
b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java
@@ -99,7 +99,7 @@ public class HddsDatanodeService extends GenericCli
implements ServicePlugin {
private HddsDatanodeHttpServer httpServer;
private boolean printBanner;
private String[] args;
- private volatile AtomicBoolean isStopped = new AtomicBoolean(false);
+ private final AtomicBoolean isStopped = new AtomicBoolean(false);
private final Map<String, RatisDropwizardExports> ratisMetricsMap =
new ConcurrentHashMap<>();
private DNMXBeanImpl serviceRuntimeInfo =
@@ -531,8 +531,7 @@ public class HddsDatanodeService extends GenericCli
implements ServicePlugin {
@Override
public void stop() {
- if (!isStopped.get()) {
- isStopped.set(true);
+ if (!isStopped.getAndSet(true)) {
if (plugins != null) {
for (ServicePlugin plugin : plugins) {
try {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
