xiaoyuyao commented on a change in pull request #191: HDDS-2488. Not enough
arguments for log messages in GrpcXceiverService.
URL: https://github.com/apache/hadoop-ozone/pull/191#discussion_r347011360
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/GrpcXceiverService.java
##########
@@ -57,7 +57,7 @@ public void onNext(ContainerCommandRequestProto request) {
dispatcher.dispatch(request, null);
responseObserver.onNext(resp);
} catch (Throwable e) {
- LOG.error("{} got exception when processing"
+ LOG.error("Got exception when processing"
+ " ContainerCommandRequestProto {}: {}", request, e);
responseObserver.onError(e);
Review comment:
": {}" should be removed here too as LOG.error take exception as parameter
by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
