xiaoyuyao commented on a change in pull request #180: HDDS-2499. IsLeader
information is lost when update pipeline state.
URL: https://github.com/apache/hadoop-ozone/pull/180#discussion_r347036818
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestSCMPipelineManager.java
##########
@@ -174,18 +174,17 @@ public void testPipelineReport() throws IOException {
Assert
.assertFalse(pipelineManager.getPipeline(pipeline.getId()).isOpen());
- // get pipeline report from each dn in the pipeline
+ // pipeline is not healthy until all dns report
PipelineReportHandler pipelineReportHandler =
new PipelineReportHandler(scmSafeModeManager, pipelineManager, conf);
- for (DatanodeDetails dn: pipeline.getNodes()) {
- PipelineReportFromDatanode pipelineReportFromDatanode =
- TestUtils.getPipelineReportFromDatanode(dn, pipeline.getId());
- // pipeline is not healthy until all dns report
- Assert.assertFalse(
- pipelineManager.getPipeline(pipeline.getId()).isHealthy());
- pipelineReportHandler
- .onMessage(pipelineReportFromDatanode, new EventQueue());
- }
+ List<DatanodeDetails> nodes = pipeline.getNodes();
Review comment:
There is a similar negative case in Line 199-205. It does not cause failure
but we can fix them similarly. The previous approach can also be fixed with
slightly modification of TestUtils.getPipelineReportFromDatanode as demoed in
the dup PR #195.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
