adoroszlai commented on issue #157: HDDS-2474. Remove OzoneClient exception Precondition check. URL: https://github.com/apache/hadoop-ozone/pull/157#issuecomment-555456802 > I think the precondition check is valid and this should be fixed properly in Ratis. @bshashikant I have no knowledge/opinion on the underlying issue. But if you feel that the check should be kept, I think explicitly "request[ing] changes" would make it more obvious. Given the current reviews, this PR may seem to be approved and someone might merge it if they miss your comment (especially when on a merging spree ;) ).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
