dineshchitlangia commented on a change in pull request #130: HDDS-2444. Remove
server side dependencies from ozonefs jar files
URL: https://github.com/apache/hadoop-ozone/pull/130#discussion_r348101010
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOMStorage.java
##########
@@ -0,0 +1,75 @@
+package org.apache.hadoop.ozone.om;
+
+import java.io.File;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hdds.HddsConfigKeys;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.test.GenericTestUtils;
+
+import org.apache.commons.io.FileUtils;
+import static org.junit.Assert.*;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+/**
+ * Testing OMStorage class.
+ */
+public class TestOMStorage {
+
+ @Rule
+ public ExpectedException thrown = ExpectedException.none();
+
+ /**
+ * Test {@link OMStorage#getOmDbDir}.
+ */
+ @Test
+ public void testGetOmDbDir() {
+ final File testDir = createTestDir();
+ final File dbDir = new File(testDir, "omDbDir");
+ final File metaDir = new File(testDir, "metaDir"); // should be ignored.
+ final Configuration conf = new OzoneConfiguration();
+ conf.set(OMConfigKeys.OZONE_OM_DB_DIRS, dbDir.getPath());
+ conf.set(HddsConfigKeys.OZONE_METADATA_DIRS, metaDir.getPath());
+
+ try {
+ assertEquals(dbDir, OMStorage.getOmDbDir(conf));
+ assertTrue(dbDir.exists()); // should have been created.
+ } finally {
+ FileUtils.deleteQuietly(dbDir);
+ }
+ }
+
+ /**
+ * Test {@link OMStorage#getOmDbDir} with fallback to OZONE_METADATA_DIRS
+ * when OZONE_OM_DB_DIRS is undefined.
+ */
+ @Test
+ public void testGetOmDbDirWithFallback() {
+ final File testDir = createTestDir();
+ final File metaDir = new File(testDir, "metaDir");
+ final Configuration conf = new OzoneConfiguration();
+ conf.set(HddsConfigKeys.OZONE_METADATA_DIRS, metaDir.getPath());
+
+ try {
+ assertEquals(metaDir, OMStorage.getOmDbDir(conf));
+ assertTrue(metaDir.exists()); // should have been created.
+ } finally {
+ FileUtils.deleteQuietly(metaDir);
+ }
+ }
+
+ @Test
+ public void testNoOmDbDirConfigured() {
+ thrown.expect(IllegalArgumentException.class);
+ OMStorage.getOmDbDir(new OzoneConfiguration());
+ }
+
+ public File createTestDir() {
+ File dir = new File(GenericTestUtils.getRandomizedTestDir(),
+ TestOMStorage.class.getSimpleName());
+ dir.mkdirs();
+ return dir;
+ }
+}
Review comment:
Missing newline at EOF
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
