adoroszlai opened a new pull request #232: HDDS-2523. BufferPool.releaseBuffer may release a buffer different than the head of the list URL: https://github.com/apache/hadoop-ozone/pull/232 ## What changes were proposed in this pull request? For standalone replication type log index is always 0. Each PutBlock's list of buffers are written to the same entry in the `commitIndex2flushedDataMap` map. Thus only the last PutBlock's buffers are released during flush. The problem was exposed during review of #205, where `IncrementalChunkBuffer` did not implement `equals()`, ie. it was the same as `==`. This caused the precondition in `BufferPool.releaseBuffer` to fail for `TestContainerMapper` (which uses standalone replication). https://issues.apache.org/jira/browse/HDDS-2523 ## How was this patch tested? `TestContainerMapper` passes with the fix, but fails with only the precondition change. Clean CI in private branch: https://github.com/adoroszlai/hadoop-ozone/runs/310502460
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
