dineshchitlangia commented on a change in pull request #234: HDDS-2531. Sonar :
remove duplicate string literals in BlockOutputStream
URL: https://github.com/apache/hadoop-ozone/pull/234#discussion_r348294132
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java
##########
@@ -622,11 +613,9 @@ private void writeChunkToContainer(ChunkBuffer chunk)
throws IOException {
throw new IOException(
"Unexpected Storage Container Exception: " + e.toString(), e);
}
- if (LOG.isDebugEnabled()) {
- LOG.debug(
- "writing chunk " + chunkInfo.getChunkName() + " blockID " + blockID
- + " length " + effectiveChunkSize);
- }
+ LOG.debug(
+ "writing chunk {} blockID {} length {}",
+ chunkInfo.getChunkName(), blockID, effectiveChunkSize);
Review comment:
NIT: rewrite it as
`LOG.debug("writing chunk {} blockID {} length {}",`
` chunkInfo.getChunkName(), blockID, effectiveChunkSize);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
