elek commented on a change in pull request #127: HDDS-2300. Publish normalized Ratis metrics via the prometheus endpoint URL: https://github.com/apache/hadoop-ozone/pull/127#discussion_r348491546
########## File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/RatisNameRewriteSampleBuilder.java ########## @@ -0,0 +1,117 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hdds.server; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +import io.prometheus.client.Collector.MetricFamilySamples.Sample; +import io.prometheus.client.dropwizard.samplebuilder.DefaultSampleBuilder; +import org.apache.logging.log4j.util.Strings; +import static org.apache.ratis.server.metrics.RatisMetrics.RATIS_APPLICATION_NAME_METRICS; + +/** + * Collect Dropwizard metrics and rename ratis specific metrics. + */ +public class RatisNameRewriteSampleBuilder extends DefaultSampleBuilder { + + private List<Pattern> followerPatterns = new ArrayList<>(); + + public RatisNameRewriteSampleBuilder() { + followerPatterns + .add(Pattern.compile( + "grpc_log_appender_follower_(.*)_(latency|success|inconsistency)" + + ".*")); + followerPatterns + .add(Pattern.compile("follower_(.*)_lastHeartbeatElapsedTime")); + followerPatterns.add(Pattern.compile("(.*)_peerCommitIndex")); + + } + + @Override + public Sample createSample(String dropwizardName, String nameSuffix, + List<String> additionalLabelNames, List<String> additionalLabelValues, + double value) { + //this is a ratis metrics, where the second part is an instance id. + if (dropwizardName.startsWith(RATIS_APPLICATION_NAME_METRICS) + || (dropwizardName.startsWith("ratis_grpc"))) { + List<String> names = new ArrayList<>(additionalLabelNames); + List<String> values = new ArrayList<>(additionalLabelValues); + String name = normalizeRatisMetric(dropwizardName, names, values); + + return super + .createSample(name, nameSuffix, + names, + values, value); + + } else { + return super + .createSample(dropwizardName, nameSuffix, additionalLabelNames, + additionalLabelValues, value); + } + } + + protected String normalizeRatisMetric(String dropwizardName, + List<String> names, + List<String> values) { + + List<String> nameParts = + new ArrayList<String>(Arrays.asList(dropwizardName.split("\\."))); + //second part is id or id@group_id + if (nameParts.size() > 2) { + String[] identifiers = nameParts.get(2).split("@"); + names.add("instance"); + values.add(identifiers[0]); + if (identifiers.length > 1) { + names.add("group"); + values.add(identifiers[1]); + } + nameParts.remove(2); + } + + if (nameParts.size() > 2) { + for (Pattern pattern : followerPatterns) { + Matcher matcher = pattern.matcher(nameParts.get(2)); + if (matcher.matches()) { + names.add("follower"); + String followerId = matcher.group(1); + values.add(followerId); + nameParts.set(2, nameParts.get(2).replace(followerId + "_", "")); + } + } + } + return Strings.join(nameParts, '.'); + } + + private String withoutSecondPart(String[] parts) { + StringBuilder builder = new StringBuilder(); + for (int i = 0; i < parts.length; i++) { + if (i != 2) { + if (i != 0) { + builder.append("."); + } + builder.append(parts[i]); + } + } + return builder.toString(); + } Review comment: thanks. deleted. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
