dineshchitlangia commented on a change in pull request #236: HDDS-2284.
XceiverClientMetrics should be initialised as part of XceiverClientManager
constructor. Contributed by Mukul Kumar Singh.
URL: https://github.com/apache/hadoop-ozone/pull/236#discussion_r348555587
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestWatchForCommit.java
##########
@@ -129,6 +129,11 @@ private String getKeyName() {
return UUID.randomUUID().toString();
}
+ private XceiverClientMetrics getXceiverClientMetrics() {
+ RpcClient rpc = (RpcClient)client.getObjectStore().getClientProxy();
+ return rpc.getXceiverClientManager().getMetrics();
+ }
+
Review comment:
Wondering if we could move this method so that we don't have to duplicate
code in 4 test classes here.
Not a deal breaker but I am just tracking Sonar code duplication stats :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
