swagle commented on a change in pull request #233: HDDS-1873 Add API to get
last completed times for every Recon task.
URL: https://github.com/apache/hadoop-ozone/pull/233#discussion_r350375595
##########
File path:
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestReconTaskControllerImpl.java
##########
@@ -161,17 +179,35 @@ public void testBadBehavedTaskBlacklisting() throws
Exception {
@Test
public void testReInitializeTasks() throws Exception {
- OMMetadataManager omMetadataManagerMock = mock(OMMetadataManager.class);
+ ReconOMMetadataManager omMetadataManagerMock = mock(
+ ReconOMMetadataManager.class);
ReconDBUpdateTask reconDBUpdateTaskMock =
getMockTask("MockTask2");
when(reconDBUpdateTaskMock.reprocess(omMetadataManagerMock))
.thenReturn(new ImmutablePair<>("MockTask2", true));
+ when(omMetadataManagerMock.getLastSequenceNumberFromDB()
+ ).thenReturn(100L);
+ long startTime = System.currentTimeMillis();
reconTaskController.registerTask(reconDBUpdateTaskMock);
reconTaskController.reInitializeTasks(omMetadataManagerMock);
+ long endTime = System.currentTimeMillis();
verify(reconDBUpdateTaskMock, times(1))
.reprocess(omMetadataManagerMock);
+
+ verify(omMetadataManagerMock, times(1)
+ ).getLastSequenceNumberFromDB();
+
+ ReconTaskStatusDao dao = new ReconTaskStatusDao(sqlConfiguration);
+ ReconTaskStatus reconTaskStatus = dao.findById("MockTask2");
+ long taskTimeStamp = reconTaskStatus.getLastUpdatedTimestamp();
+ long seqNumber = reconTaskStatus.getLastUpdatedSeqNumber();
+
+ Assert.assertTrue(startTime <= taskTimeStamp
Review comment:
These assertions for mocked values are meaningless right, instead, making
sure mocks are verified should suffice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
