hanishakoneru commented on a change in pull request #276: HDDS-2637. Handle
LeaderNot ready exception in OzoneManager StateMachine and upgrade ratis to
latest version.
URL: https://github.com/apache/hadoop-ozone/pull/276#discussion_r351547484
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java
##########
@@ -198,8 +210,12 @@ public TransactionContext startTransaction(
// only after completing 101 - 149. In initial stage, we are starting
// with single global executor. Will revisit this when needed.
+ // Add the term index and transaction log index to applyTransaction map
+ // . This map will be used to update lastAppliedIndex.
+ applyTransactionMap.put(trxLogIndex, trx.getLogEntry().getTerm());
Review comment:
Do we need to put all log indices in the applyTransactionMap? While updating
lastAppliedIndex, we would want to compare with the RaftConfChange and
MetadataChange entries only right? I might be missing something here but we
could optimize by adding only the required entries?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
