xiaoyuyao commented on a change in pull request #296: HDDS-2659.
KeyValueHandler#handleCreateContainer should log the exception on container
creation failure
URL: https://github.com/apache/hadoop-ozone/pull/296#discussion_r353955804
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/ContainerUtils.java
##########
@@ -146,6 +146,7 @@ public static ContainerCommandResponseProto
logAndReturnError(
log.info("Operation: {} , Trace ID: {} , Message: {} , Result: {}",
request.getCmdType().name(), request.getTraceID(),
ex.getMessage(), ex.getResult().getValueDescriptor().getName());
+ log.error("StorageContainerException Occurred!", ex);
Review comment:
We already have a log.info just above it with exception message and the
result. If more information about the exception is needed, can we consolidate
it into the previous message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
