swagle commented on a change in pull request #234: HDDS-2531. Sonar : remove
duplicate string literals in BlockOutputStream
URL: https://github.com/apache/hadoop-ozone/pull/234#discussion_r353959972
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java
##########
@@ -609,11 +603,8 @@ private void writeChunkToContainer(ChunkBuffer chunk)
throws IOException {
}
return e;
}, responseExecutor).exceptionally(e -> {
- if (LOG.isDebugEnabled()) {
- LOG.debug(
- "writing chunk failed " + chunkInfo.getChunkName() + " blockID "
- + blockID + " with exception " + e.getLocalizedMessage());
- }
+ LOG.debug("writing chunk failed {} blockID {} with exception {}",
Review comment:
Yes, we need to keep the explicit check for log level. The lazy evaluation
only applies to the toString() call, the expression will be fully evaluated if
any provided as a param, e.g.: e.getLocalizedMessage() above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
