[
https://issues.apache.org/jira/browse/HDDS-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Elek resolved HDDS-2661.
-------------------------------
Fix Version/s: 0.5.0
Target Version/s: 0.5.0
Resolution: Fixed
> Use field based Config annotation instead of method based
> ---------------------------------------------------------
>
> Key: HDDS-2661
> URL: https://issues.apache.org/jira/browse/HDDS-2661
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Marton Elek
> Assignee: Marton Elek
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> HDDS-2413 proposes an additional usage of the @Config annotation: to set
> configuration based on an existing configuration class.
> But as of now we annotate the setters instead of the fields. To avoid
> annotation duplication (we need to read the values from the getters or the
> fields) I propose to switch to use field based annotations instead of setter
> based annotation.
> I think it's more readable and additional validation (even the class level
> validations) can be done in a @PostConstruct method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
