hanishakoneru commented on a change in pull request #428: HDDS-2868. Add ObjectID and UpdateID to OMKeyInfo. URL: https://github.com/apache/hadoop-ozone/pull/428#discussion_r366542253
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java ########## @@ -126,6 +126,8 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, if (omKeyInfo == null) { throw new OMException("Key not found", KEY_NOT_FOUND); } + // Set the UpdateID to current transactionLogIndex + omKeyInfo.setUpdateID(transactionLogIndex); Review comment: Deleted Keys are put in DeletedKey Table and then purged when we get KeyPurgeRequest. As the purge request could also be a replay, we should only delete the keys which were deleted before the purge request. For this check, we need to set the updateID here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org