xiaoyuyao commented on a change in pull request #389: HDDS-2534. scmcli 
container delete not working
URL: https://github.com/apache/hadoop-ozone/pull/389#discussion_r366606214
 
 

 ##########
 File path: 
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java
 ##########
 @@ -293,6 +307,12 @@ public void deleteContainer(ContainerID containerID) 
throws IOException {
                 " it's missing!", containerID);
       }
       scmContainerManagerMetrics.incNumSuccessfulDeleteContainers();
+    } catch (NodeNotFoundException nnfe) {
+      scmContainerManagerMetrics.incNumFailureDeleteContainers();
+      throw new SCMException(
+          "Failed to delete container " + containerID + ", reason : " +
+              "node doesn't exist.",
 
 Review comment:
   Can we add the node info to the Exception? Is it part of the 
NodeNotFoundException?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to