bharatviswa504 commented on a change in pull request #436: HDDS-2875. Add a
config in ozone to tune max outstanding requests in …
URL: https://github.com/apache/hadoop-ozone/pull/436#discussion_r366619980
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientManager.java
##########
@@ -345,10 +337,30 @@ public void setMaxSize(int maxSize) {
this.maxSize = maxSize;
}
+ }
+
+ /**
+ * Configuration for ratis client.
+ */
+ @ConfigGroup(prefix = "dfs.ratis.client")
+ public class DFSRatisClientConfig {
+
+ @Config(key = "async.max.outstanding.requests",
Review comment:
With new-style Java config, we don't need to add, it generates an
ozone-default-generated.xml. In that file, I can see this new config.
```
[root@ozone-test-1 ex]# cat ozone-default-generated.xml | grep -A4
"dfs.ratis.client.async"
<name>dfs.ratis.client.async.max.outstanding.requests</name>
<value>64</value>
<description>Controls the maximum number of outstanding async requests
that can be handled by the Standalone as well as Ratis client.</description>
<tag>OZONE, CLIENT, PERFORMANCE</tag>
</property>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
