hanishakoneru commented on a change in pull request #271: HDDS-1812. Du while calculating used disk space reports that chunk files are file not found URL: https://github.com/apache/hadoop-ozone/pull/271#discussion_r366626979
########## File path: hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/fs/TestDedicatedDiskSpaceUsage.java ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hdds.fs; + +import org.apache.hadoop.fs.FileUtil; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +import java.io.File; +import java.io.IOException; + +import static org.apache.hadoop.hdds.fs.TestDU.createFile; +import static org.apache.hadoop.test.GenericTestUtils.getTestDir; +import static org.junit.Assert.assertTrue; + +/** + * Tests for {@link DedicatedDiskSpaceUsage}. + */ +public class TestDedicatedDiskSpaceUsage { + + private static final File DIR = + getTestDir(TestDedicatedDiskSpaceUsage.class.getSimpleName()); + + private static final int FILE_SIZE = 1024; + + @Before + public void setUp() { + FileUtil.fullyDelete(DIR); + assertTrue(DIR.mkdirs()); + } + + @After + public void tearDown() throws IOException { + FileUtil.fullyDelete(DIR); + } + + @Test + public void testGetUsed() throws IOException { + File file = new File(DIR, "data"); + createFile(file, FILE_SIZE); + SpaceUsageSource subject = new DedicatedDiskSpaceUsage(DIR); + + assertTrue(subject.getUsedSpace() >= FILE_SIZE - 20); Review comment: Can you please add a comment explaining -20 for margin of error. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
