maobaolong commented on issue #441: HDDS-2889. Make DBStore and RDBStore more commons. URL: https://github.com/apache/hadoop-ozone/pull/441#issuecomment-575957910 @avijayanhwx I think we should neither bring the OM concept into `RDBStore` nor ` RDBCheckpointManager`, and we should let the user of `RDBStore` determine if checkpoint is enabled. Yes, i do agree that it maybe not a strong requests for let checkpoint folder to be a configurable item, we just give a hard code name for it, for example "db.checkpoint". Because OM is a concept of Ozone, and `RDBStore` and ` RDBCheckpointManager` is a common components which is dependency by our program now, as a user of `RDBStore`, but not a user of Ozone, in fact, i do not need checkpoint at all in our scenario, but i think there must someone need checkpoint, and nobody want to specify the location or name of checkpoint folder now. So, i think we should create another ticket https://issues.apache.org/jira/browse/HDDS-2907 for track our discussion？For `HDDS-2889`, we just remove the OM concept.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
