hanishakoneru commented on a change in pull request #415: HDDS-2840. Implement ofs://: mkdir URL: https://github.com/apache/hadoop-ozone/pull/415#discussion_r369838294
########## File path: hadoop-ozone/ozonefs/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystemWithMocks.java ########## @@ -0,0 +1,152 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.fs.ozone; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.ozone.OmUtils; +import org.apache.hadoop.ozone.client.ObjectStore; +import org.apache.hadoop.ozone.client.OzoneBucket; +import org.apache.hadoop.ozone.client.OzoneClient; +import org.apache.hadoop.ozone.client.OzoneClientFactory; +import org.apache.hadoop.ozone.client.OzoneVolume; +import org.apache.hadoop.security.UserGroupInformation; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.powermock.api.mockito.PowerMockito; +import org.powermock.core.classloader.annotations.PowerMockIgnore; +import org.powermock.core.classloader.annotations.PrepareForTest; +import org.powermock.modules.junit4.PowerMockRunner; + +import java.net.URI; + +import static org.junit.Assert.assertEquals; +import static org.mockito.Matchers.eq; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +/** + * Ozone File system tests that are light weight and use mocks. + */ +@RunWith(PowerMockRunner.class) +@PrepareForTest({ OzoneClientFactory.class, UserGroupInformation.class }) +@PowerMockIgnore("javax.management.*") +public class TestRootedOzoneFileSystemWithMocks { + + @Test + public void testFSUriWithHostPortOverrides() throws Exception { + Configuration conf = new OzoneConfiguration(); + OzoneClient ozoneClient = mock(OzoneClient.class); + ObjectStore objectStore = mock(ObjectStore.class); + OzoneVolume volume = mock(OzoneVolume.class); + OzoneBucket bucket = mock(OzoneBucket.class); + + when(ozoneClient.getObjectStore()).thenReturn(objectStore); + when(objectStore.getVolume(eq("volume1"))).thenReturn(volume); + when(volume.getBucket("bucket1")).thenReturn(bucket); + + PowerMockito.mockStatic(OzoneClientFactory.class); + PowerMockito.when(OzoneClientFactory.getRpcClient(eq("local.host"), + eq(5899), eq(conf))).thenReturn(ozoneClient); + + UserGroupInformation ugi = mock(UserGroupInformation.class); + PowerMockito.mockStatic(UserGroupInformation.class); + PowerMockito.when(UserGroupInformation.getCurrentUser()).thenReturn(ugi); + when(ugi.getShortUserName()).thenReturn("user1"); + + // Note: FileSystem#loadFileSystems doesn't load OFS class because + // META-INF still points to org.apache.hadoop.fs.ozone.OzoneFileSystem + conf.set("fs.ofs.impl", "org.apache.hadoop.fs.ozone.RootedOzoneFileSystem"); + URI uri = new URI("ofs://local.host:5899/volume1/bucket1"); + + FileSystem fileSystem = FileSystem.get(uri, conf); + RootedOzoneFileSystem ofs = (RootedOzoneFileSystem) fileSystem; + + assertEquals(ofs.getUri().getAuthority(), "local.host:5899"); + PowerMockito.verifyStatic(); + OzoneClientFactory.getRpcClient("local.host", 5899, conf); + } + + @Test + public void testFSUriWithHostPortUnspecified() throws Exception { + Configuration conf = new OzoneConfiguration(); + final int omPort = OmUtils.getOmRpcPort(conf); + + OzoneClient ozoneClient = mock(OzoneClient.class); + ObjectStore objectStore = mock(ObjectStore.class); + OzoneVolume volume = mock(OzoneVolume.class); + OzoneBucket bucket = mock(OzoneBucket.class); + + when(ozoneClient.getObjectStore()).thenReturn(objectStore); + when(objectStore.getVolume(eq("volume1"))).thenReturn(volume); + when(volume.getBucket("bucket1")).thenReturn(bucket); + + PowerMockito.mockStatic(OzoneClientFactory.class); + PowerMockito.when(OzoneClientFactory.getRpcClient(eq("local.host"), + eq(omPort), eq(conf))).thenReturn(ozoneClient); + + UserGroupInformation ugi = mock(UserGroupInformation.class); + PowerMockito.mockStatic(UserGroupInformation.class); + PowerMockito.when(UserGroupInformation.getCurrentUser()).thenReturn(ugi); + when(ugi.getShortUserName()).thenReturn("user1"); + + URI uri = new URI("o3fs://bucket1.volume1.local.host"); + Review comment: testFSUriHostVersionDefault() and testFSUriWithHostPortUnspecified() need to be modified to test ofs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
