hanishakoneru commented on a change in pull request #448: HDDS-2870. Handle
replay of KeyCreate requests.
URL: https://github.com/apache/hadoop-ozone/pull/448#discussion_r372052286
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/file/OMFileCreateResponse.java
##########
@@ -18,24 +18,25 @@
package org.apache.hadoop.ozone.om.response.file;
-import javax.annotation.Nullable;
import javax.annotation.Nonnull;
import org.apache.hadoop.ozone.om.helpers.OmKeyInfo;
import org.apache.hadoop.ozone.om.response.key.OMKeyCreateResponse;
import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
.OMResponse;
-
-
/**
* Response for crate file request.
*/
public class OMFileCreateResponse extends OMKeyCreateResponse {
- public OMFileCreateResponse(@Nullable OmKeyInfo omKeyInfo,
- long openKeySessionID, @Nonnull OMResponse omResponse) {
- super(omKeyInfo, openKeySessionID, omResponse);
+ public OMFileCreateResponse(@Nonnull OMResponse omResponse,
+ @Nonnull OmKeyInfo omKeyInfo, long openKeySessionID) {
+ super(omResponse, omKeyInfo, openKeySessionID);
+ }
+
+ public OMFileCreateResponse(@Nonnull OMResponse omResponse) {
+ super(omResponse);
Review comment:
Thanks for catching this. If you are ok with rest of the patch, I add this
check in the next Jira HDDS-2944.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
