bharatviswa504 commented on a change in pull request #510: HDDS-2958. Handle replay of OM Volume ACL requests URL: https://github.com/apache/hadoop-ozone/pull/510#discussion_r373335649
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/acl/OMVolumeSetAclRequest.java ########## @@ -80,29 +80,36 @@ public String getVolumeName() { @Override OMClientResponse onSuccess(OMResponse.Builder omResponse, - OmVolumeArgs omVolumeArgs, boolean result){ + OmVolumeArgs omVolumeArgs, boolean aclApplied){ omResponse.setSetAclResponse(OzoneManagerProtocolProtos.SetAclResponse - .newBuilder().setResponse(result).build()); - return new OMVolumeAclOpResponse(omVolumeArgs, omResponse.build()); + .newBuilder().setResponse(aclApplied).build()); + return new OMVolumeAclOpResponse(omResponse.build(), omVolumeArgs); } @Override OMClientResponse onFailure(OMResponse.Builder omResponse, IOException ex) { - return new OMVolumeAclOpResponse(null, - createErrorOMResponse(omResponse, ex)); + return new OMVolumeAclOpResponse(createErrorOMResponse(omResponse, ex)); } @Override - void onComplete(IOException ex) { - if (ex == null) { - if (LOG.isDebugEnabled()) { - LOG.debug("Set acls: {} to volume: {} success!", - getAcls(), getVolumeName()); - } - } else { - LOG.error("Set acls {} to volume {} failed!", - getAcls(), getVolumeName(), ex); + void onComplete(Result result, IOException ex, long trxnLogIndex) { Review comment: Now no use of exception here. Unused param ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org