smengcl edited a comment on issue #528: HDDS-2979. Implement ofs://: Fix getFileStatus for mkdir volume URL: https://github.com/apache/hadoop-ozone/pull/528#issuecomment-582595351 > LGTM overall. Can we add a unit or acceptance test for the volume/bucket only creation case with ofs? As I mentioned above the exact case (where Hadoop common is involved) is hard to be covered by unit test inside `ozonefs` package. - With that said I do have tests to check volume only creation `testMkdirNonExistentVolume` and volume+bucket creation `testMkdirNonExistentVolumeBucket`. But I'm adding another test to ensure `getListStatus` won't return `null` or throw for root.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
