supratimdeka commented on a change in pull request #498: HDDS-2940. mkdir : create key table entries for intermediate directories in the path URL: https://github.com/apache/hadoop-ozone/pull/498#discussion_r376713743
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMDirectoryCreateRequest.java ########## @@ -228,10 +289,8 @@ private OmKeyInfo createDirectoryKeyInfo(OzoneManager ozoneManager, .setReplicationType(HddsProtos.ReplicationType.RATIS) .setReplicationFactor(HddsProtos.ReplicationFactor.ONE) .setFileEncryptionInfo(encryptionInfo.orNull()) - .setAcls(OzoneAclUtil.fromProtobuf(keyArgs.getAclsList())) - .setObjectID(transactionLogIndex) - .setUpdateID(transactionLogIndex) - .build(); + .setObjectID(objectId) + .setUpdateID(0); Review comment: sure, will make the change. any specific reason why it might not be a good idea? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org