hanishakoneru commented on a change in pull request #504: HDDS-2953. Handle 
replay of S3 requests
URL: https://github.com/apache/hadoop-ozone/pull/504#discussion_r377311655
 
 

 ##########
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3InitiateMultipartUploadRequest.java
 ##########
 @@ -118,6 +126,11 @@ public OMClientResponse 
validateAndUpdateCache(OzoneManager ozoneManager,
 
       validateBucketAndVolume(omMetadataManager, volumeName, bucketName);
 
+      // We do not check if this transaction is a replay here to avoid extra
+      // DB reads. Even if this transaction is replayed, in
+      // S3MultipartUploadComplete request, we would delete this entry from
 
 Review comment:
   Added a TODO in MultipartComplete request.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to