bharatviswa504 edited a comment on issue #536: HDDS-2988. Use 
getPropertiesByPrefix instead of regex in matching ratis client and server 
properties.
URL: https://github.com/apache/hadoop-ozone/pull/536#issuecomment-585471740
 
 
   > > we can use "datanode.raft.server" for RatisServer config and for client 
"datanode.raft.client" and for grpc "datanode.raft.grpc". In this way we can 
use directly ratis grouping. Is this is what you are suggesting here?
   > 
   > Exactly. Sorry if was not clear. It's a very small suggestion, and not a 
big deal.
   > 
   > My impression was that it simplifies the whole code as you don't need to 
do all the magic with the middle `[server|grpc]` tag in the 
`datanode.ratis.server.raft.server`. You can use the configuration based on the 
ratis groups.
   
   Thank You @elek for review. Addressed review comments.
   
   (With this approach, not able to use direct Ratis variables. (But I think 
that is okay, we have lost the advantage of if Ratis changes configs, we need 
to update ozone code accordingly)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to