bshashikant commented on a change in pull request #537: HDDS-2990. Set the
default value of grpc flow control window for ratis client and ratis server
URL: https://github.com/apache/hadoop-ozone/pull/537#discussion_r379298720
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/conf/RatisClientConfig.java
##########
@@ -26,9 +29,9 @@
* RaftClient creation.
*
*/
-@ConfigGroup(prefix = "raft.client")
+@ConfigGroup(prefix = RatisHelper.HDDS_DATANODE_RATIS_CLIENT_PREFIX_KEY)
public class RatisClientConfig {
- @Config(key = "async.outstanding-requests.max",
+ @Config(key = RaftClientConfigKeys.Rpc.REQUEST_TIMEOUT_KEY,
Review comment:
RaftClientConfigKeys.Rpc.REQUEST_TIMEOUT_KEY, the config key is wrong. Can
you please fix it as it denotes the max async requests count on client?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
