adoroszlai commented on issue #572: HDDS-3045. Integration test crashes due to 
ReconServer NPE
URL: https://github.com/apache/hadoop-ozone/pull/572#issuecomment-589287733
 
 
   Found the root cause: each `MiniOzoneClusterImpl` has separate `conf` 
object, which `configureRecon()` sets the "auto" address on.  But 
`ConfigurationProvider` provides the same config set in the first call, since 
it's `static` and has a `null` check.  Need to reset it for the new config to 
take effect.  The problem is that after the service is started, the actual port 
is updated into the config, so the next test case won't see the "auto" address, 
rather the port assigned in the first run.
   
   Without patch (`TestOzoneFileInterfaces` test):
   
   ```
   2020-02-20 14:44:11,599 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:40127
   2020-02-20 14:44:44,052 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:40127
   2020-02-20 14:45:09,644 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:40127
   ```
   
   With patch:
   
   ```
   2020-02-20 21:04:21,611 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:57291
   2020-02-20 21:04:38,375 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:57324
   2020-02-20 21:04:57,736 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:57355
   2020-02-20 21:05:16,921 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:57387
   2020-02-20 21:05:36,204 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:57420
   2020-02-20 21:05:55,494 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:57451
   2020-02-20 21:06:15,355 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:57485
   2020-02-20 21:06:34,756 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:57520
   2020-02-20 21:06:54,094 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:57563
   2020-02-20 21:07:13,515 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:57594
   2020-02-20 21:07:32,011 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:57648
   2020-02-20 21:07:51,967 [main] INFO  scm.ReconStorageContainerManagerFacade 
(ReconStorageContainerManagerFacade.java:start(178)) - Recon 
ScmDatanodeProtocol RPC server is listening at /0.0.0.0:57681
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to