adoroszlai commented on a change in pull request #569: HDDS-3209. Recon should persist Node metadata. URL: https://github.com/apache/hadoop-ozone/pull/569#discussion_r382145650
########## File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconNewNodeHandler.java ########## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.recon.scm; + +import java.io.IOException; + +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.scm.node.NodeManager; +import org.apache.hadoop.hdds.server.events.EventHandler; +import org.apache.hadoop.hdds.server.events.EventPublisher; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Adds the new node to Recon Node DB. Since we are not dependent on this + * update, we do this in async. + */ +public class ReconNewNodeHandler implements EventHandler<DatanodeDetails> { + + private static final Logger LOG = LoggerFactory + .getLogger(ReconNewNodeHandler.class); + private ReconNodeManager nodeManager; + + public ReconNewNodeHandler(NodeManager nodeManager) { + this.nodeManager = (ReconNodeManager) nodeManager; + } + + @Override + public void onMessage(DatanodeDetails datanodeDetails, + EventPublisher publisher) { + try { + nodeManager.addNodeToDB(datanodeDetails); + } catch (IOException e) { + LOG.error("Unable to add new node to Node DB."); Review comment: Including part of datanode info and the exception might be helpful. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
