bharatviswa504 opened a new pull request #575: HDDS-3046. Fix Retry handling in 
Rpc Client.
URL: https://github.com/apache/hadoop-ozone/pull/575
 
 
   ## What changes were proposed in this pull request?
   
   Right now for all other exceptions other than serviceException we use 
FailOverOnNetworkException.
   
   This Exception policy is created with 15 max fail overs and 15 retries. 
   
    
   
   retryPolicyOnNetworkException.shouldRetry(
    exception, retries, failovers, isIdempotentOrAtMostOnce);
   2 issues with this:
   
   When shouldRetry returns action FAILOVER_AND_RETRY, it will stuck with same 
OM, and does not perform failover to next OM.  As 
OMFailoverProxyProvider#performFailover() is a dummy call does not perform any 
failover.
   When ozone.client.failover.max.attempts is set to 15, now with 2 policies 
with each set to 15, we will retry 15*2 times in worst scenario. 
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-3046
   
   ## How was this patch tested?
   
   Deployed fix on OM HA cluster and did failover and it worked fine. And 
existing tests should cover this.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to