[ 
https://issues.apache.org/jira/browse/HDDS-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaoyu Yao updated HDDS-3057:
-----------------------------
    Fix Version/s: 0.5.0
       Resolution: Fixed
           Status: Resolved  (was: Patch Available)

Thanks [~smeng] for the contribution. The PR has been merged to master. 

> Improve Ozone Shell ACL operations' help text readability
> ---------------------------------------------------------
>
>                 Key: HDDS-3057
>                 URL: https://issues.apache.org/jira/browse/HDDS-3057
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Siyao Meng
>            Assignee: Siyao Meng
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.5.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently:
> {code:bash|title=ozone sh volume addacl -h}
> $ ozone sh volume addacl -h
> Usage: ozone sh volume addacl [-hV] -a=<acl> [-s=<storeType>] <uri>
> Add a new Acl.
>       <uri>                 URI of the volume/bucket.
>                             Ozone URI could start with o3:// or without 
> prefix. URI
>                               may contain the host and port of the OM server. 
> Both
>                               are optional. If they are not specified it will 
> be
>                               identified from the config files.
>   -a, --acl=<acl>           Add acl.r = READ,w = WRITE,c = CREATE,d = 
> DELETE,l =
>                               LIST,a = ALL,n = NONE,x = READ_AC,y = 
> WRITE_ACEx user:
>                               user1:rw or group:hadoop:rw
>   -h, --help                Show this help message and exit.
>   -s, --store=<storeType>   store type. i.e OZONE or S3
>   -V, --version             Print version information and exit.
> {code}
> {code:bash|title=ozone sh bucket addacl -h}
> $ ozone sh bucket addacl -h
> Usage: ozone sh bucket addacl [-hV] -a=<acl> [-s=<storeType>] <uri>
> Add a new Acl.
>       <uri>                 URI of the volume/bucket.
>                             Ozone URI could start with o3:// or without 
> prefix. URI
>                               may contain the host and port of the OM server. 
> Both
>                               are optional. If they are not specified it will 
> be
>                               identified from the config files.
>   -a, --acl=<acl>           new acl.r = READ,w = WRITE,c = CREATE,d = 
> DELETE,l =
>                               LIST,a = ALL,n = NONE,x = READ_AC,y = 
> WRITE_ACEx user:
>                               user1:rw or group:hadoop:rw
>   -h, --help                Show this help message and exit.
>   -s, --store=<storeType>   store type. i.e OZONE or S3
>   -V, --version             Print version information and exit.
> {code}
> Same for {{ozone sh (volume|bucket|key) (addacl|removeacl|setacl|-getacl-)}}
> It would look much nicer to have a line separator or space between {{acl.}} 
> and {{.r = READ,...}}.
> And improves the prompt on error and overall readability, and correct typo: 
> {{READ_AC -> READ_ACL}}, {{WRITE_AC -> WRITE_ACL}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to