bharatviswa504 edited a comment on issue #598: HDDS-3067. Fix Bug in Scrub Pipeline causing destory pipelines after SCM restart. URL: https://github.com/apache/hadoop-ozone/pull/598#issuecomment-590970141 > I'm not sure about the other part: maybe it's just me, but it seems to be a workaround for the behavior of the scrubber, and we are losing information (maybe not important information, I don't know). I think other possible fixes should be considered (eg. adding a new state for the restored pipelines, or introducing a "grace period" in the scrubber after startup). From my understanding, creation time stamp is set when pipeline is created. This is what we do when SCM is setup fresh and started. Now SCM is restarted, all pipelines will be in allocated state, until pipeline reports are received from datanode. So, I assume we can set the creation time with SCM start time and use this to scrub the pipeline. As scrub main purpose is to detect a pipeline is allocated state for more than configured ozone.scm.pipeline.allocated.timeout. But one thing is in DB we don't change the timestamp it will be always with creation timestamp if the pipeline is not destroyed. Let me know if you have any other approach, from above comment I have not understood the proposal clearly. > It seems that the two changes are not strictly related: the fix for the test is correct by itself, the test passes with or without the call to pipeline.setCreationTimestamp. Yes, test fix is not related to this, as I am looking for any tests testing Ratis pipeline I have found this and fixed it as part of this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
